fix(python-sdk): log websocket cleanup failures#1127
Conversation
|
CI note from autonomous fixer: Targeted local checks for the scoped change are green:
Required generated-sync checks are currently red from pre-existing/unrelated generator drift on this base, not from this websocket change:
Per PMXT focused-PR generated-drift policy, I am keeping this PR scoped to #1106 and not folding broad SDK/API-reference regeneration into it. |
PR Review: PASS (NOT VERIFIED)What This DoesLogs WebSocket cleanup failures during retry after a failed connection attempt instead of silently swallowing Blast RadiusPython SDK WebSocket client cleanup path and its unit tests only. No sidecar API contract, venue exchange logic, generated SDK files, or field propagation changes. Consumer VerificationBefore (base branch): try:
ws.close()
except Exception:
passAfter (PR branch): This verifies the cleanup failure is now observable without changing the retry outcome. Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- diagnostic-only bug fix with unchanged public API and unchanged final failure semantics. RiskI could not run the pytest suite in this environment because |
Summary
pmxt_internalartifacts in a focused checkoutFixes #1106
Test Plan
cd sdks/python && /opt/hermes/.venv/bin/python -m pytest tests/test_ws_client.py -q/opt/hermes/.venv/bin/python -m py_compile sdks/python/pmxt/ws_client.py sdks/python/tests/test_ws_client.pygit diff --check