feat(router): add SQL query support to both SDKs#1129
Conversation
3445b09 to
7860f91
Compare
PR Review: FAILWhat This DoesAdds Blast RadiusRouter SDK layer only: Python router export/method and TypeScript router export/method. The sidecar/core SQL endpoint already exists under Consumer VerificationBefore (base branch): After (PR branch): url = f"{self._resolve_sidecar_host()}/v0/sql"However the TypeScript method calls: await this.sidecarReadRequest('sql', { query }, [{ query }])
Test Results
Findings
PMXT Pipeline Check
Semver Impactminor -- adds a new Router SQL SDK method. RiskPython appears to target the right endpoint, but TypeScript is not safe to ship as-is because its public method will not reach the intended |
…ql() - Use resolveBaseUrl() for /v0/sql endpoint - Use fetchWithRetry() for robust network calls - Add proper auth headers Fixes pmxt-dev#1032
PR Updated ✅TypeScript SQL Fix:
Verification:
Ready for re-review! 🙏 |
PR Review: PASS (NOT VERIFIED)What This DoesAdds Blast RadiusPython SDK router/export surface and TypeScript SDK router/export surface. The core Consumer VerificationBefore (base branch): router.sql("SELECT 1 AS one")
# base branch: method is absent from sdks/python/pmxt/router.pyawait router.sql('SELECT 1 AS one')
// base branch: method is absent from sdks/typescript/pmxt/router.tsAfter (PR branch): POST /v0/sql {"query":"SELECT 1 AS one"}{
"error": "service_unavailable",
"message": "SQL query service is not available. Configure CLICKHOUSE_HTTP_URL or use the hosted PMXT Enterprise SQL endpoint."
}Python files compile, and the new SDK methods are present. Full SDK consumer verification against a live SQL backend was not possible in this environment. Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactminor -- adds new public SDK methods/types. RiskThe actual SQL query path could not be verified without a configured SQL backend. There are also no regression tests proving the Python/TypeScript SDK methods parse successful SQL responses, so this review is limited to static SDK inspection plus route reachability/service-unavailable evidence. |
Fixes #1032