fix(ts-sdk): forward router match browse options#1152
Conversation
|
Verification note from low-fruit automation:
Keeping this PR scoped to #1149 rather than folding broad generated drift into it. |
PR Review: PASS (NOT VERIFIED)What This DoesAdds the missing TypeScript SDK Blast RadiusTypeScript SDK router wrapper only: Consumer VerificationBefore (base branch): await router.fetchMarketMatches({ minDifference: 0.1, sort: 'priceDifference' })
// base source: no minDifference/sort option types; no query.minDifference/query.sort forwardingAfter (PR branch): The actual SDK build/E2E run was not completed because this review checkout lacks generated TypeScript OpenAPI artifacts ( Test Results
FindingsNo blocking findings. PMXT Pipeline Check
Semver Impactpatch -- fixes an SDK wrapper omission without changing the server contract. RiskThere is no regression test covering the new query forwarding, and full TypeScript SDK build was blocked by missing generated artifacts in this review environment, so I verified the forwarding statically rather than through a compiled SDK call. |
Summary
Router.fetchMarketMatchesoption fields forminDifferenceandsort.Closes #1149
Test Plan
node - <<'NODE' ... typescript.transpileModule(sdks/typescript/pmxt/router.ts) ... NODE— router.ts transpile diagnostics cleangit diff --checknpm run build --workspace=pmxtjsattempted afternpm install; blocked by missing generatedsdks/typescript/generated/src/index.jsin this checkoutnpm run generate:sdk:typescript --workspace=pmxt-coreattempted to restore generated SDK; blocked by environment missingjava