Skip to content

fix(sdks): use outcomeId in GET query for fetchOHLCV/fetchTrades #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realfishsam merged 1 commit into from
Jun 19, 2026
Merged

fix(sdks): use outcomeId in GET query for fetchOHLCV/fetchTrades #1162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/exchanges/hyperliquid/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export class HyperliquidExchange extends PredictionMarketExchange {
return this.normalizer.normalizeOrderBook(raw, outcomeId);
}

async fetchOHLCV(outcomeId: string, params: OHLCVParams = {}): Promise<PriceCandle[]> {
async fetchOHLCV(outcomeId: string, params: OHLCVParams = { resolution: '1h' }): Promise<PriceCandle[]> {
const raw = await this.fetcher.fetchRawOHLCV(outcomeId, params);
return this.normalizer.normalizeOHLCV(raw, params);
}
Expand Down
4 changes: 2 additions & 2 deletions sdks/python/pmxt/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,7 +2235,7 @@ def fetch_ohlcv(
params_dict[key] = value

args = [outcome_id, params_dict]
query = {"id": outcome_id, **params_dict}
query = {"outcomeId": outcome_id, **params_dict}
data = self._handle_response(
self._sidecar_read_request("fetchOHLCV", query, args)
)
Expand Down Expand Up @@ -2295,7 +2295,7 @@ def fetch_trades(
params_dict[key] = value

args = [outcome_id, params_dict]
query = {"id": outcome_id, **params_dict}
query = {"outcomeId": outcome_id, **params_dict}
data = self._handle_response(
self._sidecar_read_request("fetchTrades", query, args)
)
Expand Down
4 changes: 2 additions & 2 deletions sdks/typescript/pmxt/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1750,7 +1750,7 @@ export abstract class Exchange {
}

const args = [resolvedOutcomeId, paramsDict];
const query = { id: resolvedOutcomeId, ...paramsDict };
const query = { outcomeId: resolvedOutcomeId, ...paramsDict };
const json = await this.sidecarReadRequest('fetchOHLCV', query, args);
const data = this.handleResponse(json);
return data.map(convertCandle);
Expand Down Expand Up @@ -1791,7 +1791,7 @@ export abstract class Exchange {
}

const args = [resolvedOutcomeId, paramsDict];
const query = { id: resolvedOutcomeId, ...paramsDict };
const query = { outcomeId: resolvedOutcomeId, ...paramsDict };
const json = await this.sidecarReadRequest('fetchTrades', query, args);
const data = this.handleResponse(json);
return data.map(convertTrade);
Expand Down
Loading