Modified change labeled as remove/add

[byzod]

A

{
  "hp_bar_enabled": false,
  "sct_color_normal": [
    255,
    255,
    255
  ],
  "sct_color_large": [
    255,
    210,
    40
  ],
  "sct_color_massive": [
    255,
    80,
    30
  ],
}

B

{
  "hp_bar_enabled": true,
  "sct_color_normal": [
    247,
    247,
    247
  ],
  "sct_color_large": [
    255,
    210,
    40
  ],
  "sct_color_massive": [
    255,
    107,
    30
  ],
}

[pnedev]

Hi @byzod ,

I don't see a problem here. The decision if a line is changed and not totally different depends on how big is the matching portion between the lines. This is configurable in the plugin settings -> 'line resemblance' in the colors section. It also depends on the active ignore options - if spaces are ignored those are not counted as a match (because they are ignored) and this might lead to marking the lines as totally replaced (added - removed).

Example:
For lines 4 - if spaces are ignored the lines are 255, vs. 247,. As 255 and 247 are different numbers so they don't match at all, only the following commas , match. So the lines size is 4 + 4 chars and the matching parts are the commas - 1 + 1 chars. This leads to 2 / 8 = 25% matching line portion. If in Settings the resemblance percentage is above 25 then the plugin considers the the lines resemblance is not enough to mark them changed so it leaves them as added/removed.

[byzod]

I get it, space are ignored, then it looks like a modify obviously for flesh cpu but for computer it's remove/add no matter what

This works as expected, I treated it as the same input in mind

---

Me be like:

[pnedev]

Hi again @byzod ,
I don't follow.... Is there actually a problem here? I really don't see it.
You can directly close the issue if there is no problem or please elaborate more what you would expect the behavior to be.
Thanks!

[pnedev]

@byzod ,
I'm closing the issue now. If you'd like to add something please write here and I could reopen it again if need be.