47328 refactor(WorkflowLog): simplify user ID handling in comments and reactions

Author: pneumatic-ilyacedrik

frontend/src/public/components/Workflows/WorkflowLog/WorkflowLogEvents/WorkflowLogTaskComment/WorkflowLogTaskComment.tsx

@@ -26,7 +26,7 @@ import {
 } from '../../../../icons';
 import { RichEditor } from '../../../../RichEditor';
 import { type TMentionData } from '../../../../RichEditor/types';
-import { IAccount, TUserListItem } from '../../../../../types/user';
+import { TUserListItem } from '../../../../../types/user';
 import { useStatePromise } from '../../../../../hooks/useStatePromise';
 import { TUploadedFile } from '../../../../../utils/uploadFiles';
 import { IEditComment } from '../../../../../api/workflows/editComment';
@@ -90,7 +90,7 @@ export function WorkflowLogTaskComment({
   const handleReactionComment = (value: string) => {
     if (workflowStatus === EWorkflowStatus.Finished) return;
 
-    if (value in reactions && reactions[value].indexOf(currentUserId as Pick<IAccount, 'id'>) !== -1) {
+    if (value in reactions && reactions[value].includes(currentUserId)) {
       deleteReactionComment({ id, value });
     } else {
       createReactionComment({ id, value });
@@ -263,14 +263,14 @@ export function WorkflowLogTaskComment({
     return typeMap[type];
   };
 
-  const renderListUsers = (list: Pick<IAccount, 'id'>[]) => {
+  const renderListUsers = (userIds: number[]) => {
     return (
       <ul className={styles['comment__watch-list']}>
-        {list.map((userWatch) => {
-          const user = getUserById(users, userWatch.id);
+        {userIds.map((listedUserId) => {
+          const user = getUserById(users, listedUserId);
 
           return (
-            <li key={userWatch.id}>{user ? getUserFullName(user) : null}</li>
+            <li key={listedUserId}>{user ? getUserFullName(user) : null}</li>
           );
         })}
       </ul>

frontend/src/public/redux/realtime/utils/__tests__/mapWorkflowLogEventFromWs.test.ts

@@ -87,8 +87,8 @@ describe('mapWsEnvelopeToWorkflowLogItem', () => {
       task: null,
       delay: null,
       attachments: [],
-      watched: [{ date: '2024-01-01T01:00:00Z', userId: { id: 3 } }],
-      reactions: { '👍': [{ id: 3 }] },
+      watched: [{ date: '2024-01-01T01:00:00Z', userId: 3 }],
+      reactions: { '👍': [3] },
     };
 
     const result = mapWsEnvelopeToWorkflowLogItem({

frontend/src/public/types/workflow.ts

@@ -1,4 +1,4 @@
-import { IAccount, TUserId } from './user';
+import { TUserId } from './user';
 import { TUploadedFile } from '../utils/uploadFiles';
 import { ITask, ITemplateStep, TaskWithTsp } from './tasks';
 import {
@@ -102,8 +102,8 @@ export interface IWorkflowLogItem {
   targetUserId: number | null;
   targetGroupId: number | null;
   attachments: [];
-  watched: { date: string; userId: Pick<IAccount, 'id'> }[];
-  reactions: { [value: string]: Pick<IAccount, 'id'>[] };
+  watched: { date: string; userId: number }[];
+  reactions: { [value: string]: number[] };
 }
 
 export interface IWorkflowDelay {