Skip to content

Commit 9175c72

Browse files
authored
Merge pull request #178 from pneumaticapp/backend/notifications/45267__update_complete_workflow_notification
Backend/notifications/45267 update complete workflow notification
2 parents f6730d3 + f681d6b commit 9175c72

2 files changed

Lines changed: 174 additions & 254 deletions

File tree

backend/src/notifications/tasks.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -717,21 +717,18 @@ def _send_completed_workflow_notification(
717717
.get(id=workflow_id)
718718
)
719719
if workflow.is_external:
720-
workflow_starter_name = 'External User'
721-
workflow_starter_photo = None
722-
else:
723-
workflow_starter_name = workflow.workflow_starter.name
724-
workflow_starter_photo = workflow.workflow_starter.photo
720+
return
721+
workflow_starter_name = workflow.workflow_starter.name
722+
workflow_starter_photo = workflow.workflow_starter.photo
725723

726724
workflow_json = NotificationWorkflowSerializer(instance=workflow).data
727725
users = (
728-
TaskPerformer.objects
729-
.acd_task_status()
730-
.users()
731-
.by_workflow(workflow_id)
732-
.exclude_directly_deleted()
733-
.order_by('id')
734-
.get_user_ids_name_emails_subscriber_set()
726+
(
727+
workflow.workflow_starter.id,
728+
workflow.workflow_starter.email,
729+
workflow.workflow_starter.first_name,
730+
True,
731+
),
735732
)
736733
link = f'{settings.FRONTEND_URL}/workflows/{workflow_id}'
737734

0 commit comments

Comments
 (0)