Merge pull request #171 from pneumaticapp/backend/template/45205__500_delete_templates

45205 backend [ templates ] DELETE /templates/{id} returns HTTP 500 instead of 204

Author: EBirkenfeld

backend/src/processes/tests/test_views/test_templates/test_destroy.py

@@ -9,9 +9,6 @@
     create_test_user,
     create_test_workflow,
 )
-from src.processes.views.template import (
-    TemplateIntegrationsService,
-)
 
 pytestmark = pytest.mark.django_db
 
@@ -86,47 +83,3 @@ def test_destroy__type_onboarding_admin__not_found(
         # assert
         assert response.status_code == 404
         analysis_mock.assert_not_called()
-
-    def test_destroy__api_request__ok(
-        self,
-        mocker,
-        api_client,
-    ):
-        # arrange
-        account = create_test_account()
-        user = create_test_user(account=account)
-        template = create_test_template(user)
-        user_agent = 'Mozilla'
-        get_user_agent_mock = mocker.patch(
-            'src.processes.views.template.get_user_agent',
-            return_value=user_agent,
-        )
-        service_init_mock = mocker.patch.object(
-            TemplateIntegrationsService,
-            attribute='__init__',
-            return_value=None,
-        )
-        api_request_mock = mocker.patch(
-            'src.processes.services.templates.'
-            'integrations.TemplateIntegrationsService.api_request',
-        )
-        api_client.token_authenticate(
-            user=user,
-            token_type=AuthTokenType.API,
-        )
-
-        # act
-        response = api_client.delete(f'/templates/{template.id}')
-
-        # assert
-        assert response.status_code == 204
-        get_user_agent_mock.assert_called_once()
-        api_request_mock.assert_called_once_with(
-            template=template,
-            user_agent=user_agent,
-        )
-        service_init_mock.assert_called_once_with(
-            account=user.account,
-            is_superuser=False,
-            user=user,
-        )

backend/src/processes/views/template.py

@@ -558,16 +558,6 @@ def destroy(self, request, *args, **kwargs):
             auth_type=request.token_type,
             is_superuser=request.is_superuser,
         )
-        if self.request.token_type == AuthTokenType.API:
-            service = TemplateIntegrationsService(
-                account=request.user.account,
-                is_superuser=request.is_superuser,
-                user=request.user,
-            )
-            service.api_request(
-                template=template,
-                user_agent=get_user_agent(request),
-            )
         return self.response_ok()
 
     @action(methods=['GET'], detail=False, url_path='titles-by-workflows')