Merge pull request #177 from pneumaticapp/backend/tasks/44805__remove_empty_placeholders

Backend/tasks/44805  remove empty placeholders

Author: pneumojoseph

backend/src/processes/models/workflows/task.py

@@ -223,7 +223,6 @@ def _get_raw_performers_fields_dict(
                 api_names.add(raw_performer_template['field']['api_name'])
         if api_names:
             fields_dict = self.workflow.get_fields_as_dict(
-                tasks_filter_kwargs={'task__number__lt': self.number},
                 fields_filter_kwargs={
                     'type': FieldType.USER,
                     'api_name__in': api_names,
@@ -368,7 +367,6 @@ def update_performers(
 
         if api_names:
             user_fields = self.workflow.get_fields(
-                tasks_filter_kwargs={'task__number__lt': self.number},
                 fields_filter_kwargs={
                     'type': FieldType.USER,
                     'api_name__in': api_names.keys(),

backend/src/processes/serializers/workflows/mixins.py

@@ -3,7 +3,6 @@
 from django.contrib.auth import get_user_model
 
 from src.processes.consts import WORKFLOW_NAME_LENGTH
-from src.processes.enums import TaskStatus
 from src.processes.serializers.workflows.kickoff_value import (
     KickoffValueSerializer,
 )
@@ -26,8 +25,7 @@ def _update_tasks(
         if is_urgent is not None and not update_fields_values:
             tasks.update(is_urgent=is_urgent)
         elif update_fields_values:
-            fields_values = self.instance.get_fields_markdown_values(
-                tasks_filter_kwargs={'task__status': TaskStatus.COMPLETED})
+            fields_values = self.instance.get_fields_markdown_values()
             for task in tasks:
                 task_service = TaskService(
                     instance=task,

backend/src/processes/serializers/workflows/workflow.py

@@ -216,11 +216,6 @@ class Meta:
     is_urgent = serializers.BooleanField(required=False)
     due_date_tsp = TimeStampField(required=False, allow_null=True)
 
-    def validate_due_date(self, value):
-        if value and value <= timezone.now():
-            raise ValidationError(messages.MSG_PW_0051)
-        return value
-
     def validate_due_date_tsp(self, value):
         if value and value <= timezone.now():
             raise ValidationError(messages.MSG_PW_0051)
@@ -308,7 +303,7 @@ def validate(self, attrs):
             Q(id=task_id) | Q(api_name=task_api_name),
         ).first()
         if task is None:
-            raise ValidationError(messages.MSG_PW_0076)
+            raise ValidationError(messages.MSG_PW_0077)
         if not task.is_active:
             raise ValidationError(messages.MSG_PW_0086)
 

backend/src/processes/services/tasks/task_version.py

@@ -8,7 +8,6 @@
     send_new_task_notification,
     send_removed_task_notification, send_new_task_websocket,
 )
-from src.processes.enums import TaskStatus
 from src.processes.models.workflows.checklist import (
     ChecklistSelection,
 )
@@ -415,20 +414,18 @@ def update_from_version(
         """
 
         workflow = kwargs['workflow']
-        completed_tasks_fields_values = workflow.get_fields_markdown_values(
-            tasks_filter_kwargs={'task__status': TaskStatus.COMPLETED},
-        )
+        tasks_fields_values = workflow.get_fields_markdown_values()
         self._create_or_update_instance(
             data=data,
             workflow=workflow,
-            fields_values=completed_tasks_fields_values,
+            fields_values=tasks_fields_values,
         )
         self._update_fields(data=data.get('fields'))
         self._update_conditions(data=data.get('conditions'))
         self._update_checklists(
             data=data.get('checklists'),
             version=version,
-            fields_values=completed_tasks_fields_values,
+            fields_values=tasks_fields_values,
         )
         self._update_delay(new_duration=data.get('delay'))
         # Don't snooze active tasks if delay created

backend/src/processes/services/workflow_action.py

@@ -318,16 +318,10 @@ def skip_task(
             instance=task,
             user=self.user or self.workflow.account.get_owner(),
         )
-        fields_values = self.workflow.get_fields_markdown_values(
-            tasks_filter_kwargs={'task__status__in': (
-                TaskStatus.COMPLETED, TaskStatus.SKIPPED,
-            )},
-        )
-
+        fields_values = self.workflow.get_fields_markdown_values()
         fields_values['workflow-starter'] = get_workflow_starter_name(
             self.workflow.workflow_starter,
         )
-
         task_service.insert_fields_values(fields_values=fields_values)
 
         WorkflowEventService.task_skip_event(task)
@@ -639,16 +633,10 @@ def start_task(
             instance=task,
             user=self.user or self.workflow.account.get_owner(),
         )
-        fields_values = self.workflow.get_fields_markdown_values(
-            tasks_filter_kwargs={'task__status__in': (
-                TaskStatus.COMPLETED, TaskStatus.SKIPPED,
-            )},
-        )
-
+        fields_values = self.workflow.get_fields_markdown_values()
         fields_values['workflow-starter'] = get_workflow_starter_name(
             self.workflow.workflow_starter,
         )
-
         task_service.insert_fields_values(fields_values=fields_values)
         task.update_performers(restore_performers=True)
         task_performers_exists = (

backend/src/processes/tests/fixtures.py

@@ -166,6 +166,7 @@ def create_test_user(
 ) -> UserModel:
 
     """
+        TODO Do not call directly!
         Creating users with custom configuration.
         Instead of this method use:
         - create_test_owner