Fix return type of CrFwGetCurrentTime()#1
Open
LeUlukai wants to merge 1 commit into
Open
Conversation
The declaration from cordetfw and the definitions in the examples did not match.
Contributor
|
Thanks for the contribution. Your fix looks OK. But please note that, starting from the current release of the cordetfw (Release 1.0.0), we are no longer supporting/maintaining the cordetfw-examples. The cordetfw-examples project was created as a test bed for the cordetfw at a time when there were no industrial applications of the cordetfw but release 1.0.0 of the cordetfw has some industrial heritage and is being used in a couple of industrial projects and therefore we believe that we no longer need the cordetfw-examples project. I will make this point clear in the project description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building on Ubuntu 18.04 with
gccversion 7.4.0, the compilation ofcordetfw-examplesfails withThe declaration of
CrFwGetCurrentTime()inCrFwTime.hand the defintion in the master and slave applications do not match -- they differ in the return type:CrFwTimeStamp_tvs.CrFwTime_t.This PR just changes the return types of the definitions in the example files to match them with the declaration in
cordetfw.The variable
dummyTime, which is returned in the definitions ofCrFwGetCurrentTime(), has also the typeCrFwTimeStamp_t, so this change should be fine here.