Add outlook calendargroup get command. Closes #7111#7166
Open
AlejandroGispert wants to merge 3 commits intopnp:mainfrom
Open
Add outlook calendargroup get command. Closes #7111#7166AlejandroGispert wants to merge 3 commits intopnp:mainfrom
AlejandroGispert wants to merge 3 commits intopnp:mainfrom
Conversation
AlejandroGispert
force-pushed
the
feature/outlook-calendargroup-get
branch
from
46032d6 to
3da5852
Compare
AlejandroGispert
force-pushed
the
feature/outlook-calendargroup-get
branch
from
e63aaba to
d002fb8
Compare
Contributor
Author
|
Hi @milanholemans @MartinM85 , Can you check my PR? |
There was a problem hiding this comment.
Pull request overview
Adds the missing m365 outlook calendargroup get command to the CLI for Microsoft 365 to retrieve a specific Outlook calendar group for a user, supporting lookup by either --id or --name, and documenting/validating delegated vs app-only behavior.
Changes:
- Introduces
outlook calendargroup getcommand implementation with Zod validation and Graph calls - Adds unit tests covering key permission/lookup scenarios
- Adds documentation page and wires it into the Docusaurus sidebar
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/m365/outlook/commands/calendargroup/calendargroup-get.ts | Implements the new calendargroup get command, including permission handling and name-to-id resolution |
| src/m365/outlook/commands/calendargroup/calendargroup-get.spec.ts | Adds unit tests for the new command (id/name, delegated/app-only, shared-scope handling) |
| src/m365/outlook/commands.ts | Registers the new command name constant |
| docs/src/config/sidebars.ts | Adds the new command docs page to the Outlook sidebar group |
| docs/docs/cmd/outlook/calendargroup/calendargroup-get.mdx | Adds reference documentation for outlook calendargroup get |
Contributor
Author
|
Hi @milanholemans @MartinM85 , Can you check my PR? |
MartinM85
requested changes
Apr 2, 2026
Contributor
MartinM85
left a comment
MartinM85
left a comment
There was a problem hiding this comment.
Hi @AlejandroGispert, great start 👍.
I have a couple of comments, nothing major.
Contributor
Author
|
thanks for the corrections. i am on it |
Made-with: Cursor
…rs for API requests - Updated the command to encode user identifiers before constructing API URLs. - Adjusted test cases to reflect changes in user identifier handling.
AlejandroGispert
force-pushed
the
feature/outlook-calendargroup-get
branch
2 times, most recently
from
47f50d4 to
c4f8bfe
Compare
- Revised examples in the documentation to include actual calendar group data. - Refactored the `OutlookCalendarGroupGetCommand` to improve handling of calendar group retrieval by name. - Removed the default properties method and streamlined the command action for better clarity and functionality. Add `CALENDARGROUP_GET` command and update tests - Introduced the `CALENDARGROUP_GET` command to retrieve calendar groups. - Updated test cases to reflect changes in API request handling and removed unnecessary resolved calendar group ID references. - Simplified expected API URLs in tests for better clarity. Add test for retrieving calendar group by name with verbose output - Implemented a new test case to verify the retrieval of a calendar group by name for the signed-in user when verbose output is enabled. - Enhanced logging assertions to ensure correct output during the command execution. - Stubbed API request to simulate expected behavior for the test scenario.
AlejandroGispert
force-pushed
the
feature/outlook-calendargroup-get
branch
from
bdfc1a9 to
e2943d1
Compare
Contributor
Author
|
Hi @MartinM85 : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7111
Summary
Adds the missing m365 outlook calendargroup get command to retrieve a specific calendar group for a user, supporting lookup by either --id or --name (with --name resolving to an id via OData filtering).
Details
Implements m365 outlook calendargroup get with delegated vs app-only permission handling.
Enforces mutually exclusive --id/--name and --userId/--userName.
Adds unit tests and a docs page, and wires the command into the docs sidebar.