New command: spo folder archive. Closes #7181#7239
Conversation
|
Thanks! We'll try to review it ASAP. |
Adam-it
left a comment
There was a problem hiding this comment.
@Saurabh7019 solid work and I only noticed one thing to correct, but I have a few things we need to recheck before we proceed:
- If we execute this command on the library root level, we get a quite confusing error message, which does not help the user. If archiving on the root level of the document library is not possible, it would be best if we handle and catch this case and present a valuable error message to the user
- I tested it locally, but I am not sure how to check if the folder is indeed archived 😁. I tried retrieving properties for that folder or any documents in that folder, and unfortunately non of them had any archived flag set. How did you test this command?
This is fixed.
You are right.. folder properties don't have an archival status. I tested it was by manually navigating to the folder in the UI and verifying that all files within the folder were archived. also, the archival can take some time to complete, so the status won't always be reflected immediately after the command runs. Let me know if you want me to include the below response for command execution, I chose not include it to keep it aligned with file-archive command. |
|
hi, due to a patch release, we needed to perform we had to rebase the main branch, which now makes this PR out of sync with the latest state of main. |
Closes #7181