Skip to content

Fixes 'Outlook Calendar Get' validation and permissions issues. Closes #7249 #7259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinM85 merged 2 commits into from
May 28, 2026
Merged

Fixes 'Outlook Calendar Get' validation and permissions issues. Closes #7249 #7259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3482cbf
Fixes 'Outlook Calendar Get' validation and permissions issues
Saurabh7019 May 16, 2026
0fd88ef
Fixes 'Outlook Calendar Get' validation and permissions issues
Saurabh7019 May 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/docs/cmd/outlook/calendar/calendar-get.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,16 @@ m365 outlook calendar get [options]
<Tabs>
<TabItem value="Delegated">

| Resource | Permissions |
|-----------------|--------------------|
| Microsoft Graph | Calendar.ReadBasic |
| Resource | Permissions |
|-----------------|----------------|
| Microsoft Graph | Calendars.Read |

</TabItem>
<TabItem value="Application">

| Resource | Permissions |
|-----------------|--------------------|
| Microsoft Graph | Calendar.ReadBasic |
| Resource | Permissions |
|-----------------|----------------|
| Microsoft Graph | Calendars.Read |

</TabItem>
</Tabs>
Expand Down Expand Up @@ -162,4 +162,4 @@ m365 outlook calendar get --userId b743445a-112c-4fda-9afd-05943f9c7b36 --calend
```

</TabItem>
</Tabs>
</Tabs>
10 changes: 9 additions & 1 deletion src/m365/outlook/commands/calendar/calendar-get.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ describe(commands.CALENDAR_GET, () => {

afterEach(() => {
sinonUtil.restore([
request.get
request.get,
calendarGroup.getUserCalendarGroupByName
]);
});

Expand Down Expand Up @@ -111,6 +112,13 @@ describe(commands.CALENDAR_GET, () => {
assert.notStrictEqual(actual.success, true);
});

it('fails validation if neither userId nor userName is specified', () => {
const actual = commandOptionsSchema.safeParse({
id: calendarId
});
assert.notStrictEqual(actual.success, true);
});

it('fails validation if userId is not a valid GUID', () => {
const actual = commandOptionsSchema.safeParse({
id: calendarId,
Expand Down
2 changes: 1 addition & 1 deletion src/m365/outlook/commands/calendar/calendar-get.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class OutlookCalendarGetCommand extends GraphCommand {
.refine(options => [options.id, options.name].filter(x => x !== undefined).length === 1, {
error: 'Specify either id or name, but not both'
})
.refine(options => !(options.userId && options.userName), {
.refine(options => [options.userId, options.userName].filter(x => x !== undefined).length === 1, {
error: 'Specify either userId or userName, but not both'
})
.refine(options => !(options.calendarGroupId && options.calendarGroupName), {
Expand Down
Loading