Ensure Unique Temporary File Names and Guaranteed Clean-up

[bhc-wp]

This pull request introduces improvements to address file handling issues encountered during site collection creation.

Key Changes

1. Unique Temporary File Names:

   • Appended a unique identifier (GUID) to temporary file names to prevent collisions.

2. Ensured File Deletion:

   • Encapsulated resource file operations within a try-finally block to guarantee that temporary files are deleted after processing.

Details

The changes are implemented in the SaveResourceValues method in src/lib/PnP.Framework/Provisioning/ObjectHandlers/Extensions/UserResourceExtensions.cs.

Stack Trace Example:
Here's an example stack trace that demonstrates the issue:

System.Resources.ResourceReader.ReadResources
System.Resources.ResourceReader..ctor
PnP.Framework.Provisioning.ObjectHandlers.Extensions.UserResourceExtensions.SaveResourceValues
PnP.Framework.Provisioning.ObjectHandlers.ObjectLocalization.ExtractObjects
PnP.Framework.Provisioning.ObjectHandlers.SiteToTemplateConversion.GetRemoteTemplate
Microsoft.SharePoint.Client.WebExtensions.GetProvisioningTemplate
WorkPoint.Core.ProvisioningProvider.ExportSiteCollection

[Adam-it]

@bhc-wp first of all sorry for the late reply from our side.
May I kindly ask you to explain how can I reporduce the issue to test out the PR? I provisioned a lot of sites and never bumped into any issues related to file provisioning?