Support modernheaderfooter for pnp.framework#1180
Draft
czullu wants to merge 4 commits into
Draft
Conversation
added 4 commits
September 8, 2025 13:32
rebuild from webProperties and use pnp.core BrandingManager Open to implement: "footerbackgroundimageurl", "footerbackgroundimagefocalpoint", "backgroundimageurl"
fix SiteFooter - Url needs decoding
| //Header Background Image | ||
| var backgroundImageUrl = web.GetPropertyBagValueString("BackgroundImageUrl", ""); | ||
| if (!string.IsNullOrWhiteSpace(backgroundImageUrl)) | ||
| { |
There was a problem hiding this comment.
I think you are missing a Uri.UnescapeDataString here
| web.Context.ExecuteQueryRetry(); | ||
| ClientResult<Stream> stream = file.OpenBinaryStream(); | ||
| web.Context.ExecuteQueryRetry(); | ||
|
|
There was a problem hiding this comment.
And you are missing a
web.EnsureProperty(f => f.ServerRelativeUrl); I think because when I was running it gave a property is not loaded exception
Member
|
@czullu the related PR in the PnP Core repo needs a bit of attention before we merge it and then we may proceed with this one. I will set it as draft for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on pnp/pnpcore#1691