Pnp#728 - Added retry when creation status is 3 and the error message is blank#740
Open
jekeblad wants to merge 1 commit into
Open
Pnp#728 - Added retry when creation status is 3 and the error message is blank#740jekeblad wants to merge 1 commit into
jekeblad wants to merge 1 commit into
Conversation
Contributor
|
@jekeblad : sitestatus 3 means there was an error, 4 means there's a naming conflict...I don't think it's good to keep retrying in those cases. Have you seen provisioning stop early with error 3 but still succeed? |
Author
|
Hi Bert.
Yes, its strange. Since I never got any error message in the response, I tried again and everything went fine.
I cant remember that it took more than one retry to get it to work I have not seen any side effect of this.
Regards
//Joakim
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows
From: Bert ***@***.***>
Sent: Thursday, 13 October 2022 11:42
To: ***@***.***>
Cc: Joakim ***@***.***>; ***@***.***>
Subject: Re: [pnp/pnpframework] pnp#728 - Added retry when creation status is 3 and the error message is blank (PR #740)
@jekeblad<https://github.com/jekeblad> : sitestatus 3 means there was an error, 4 means there's a naming conflict...I don't think it's good to keep retrying in those cases. Have you seen provisioning stop early with error 3 but still succeed?
—
Reply to this email directly, view it on GitHub<#740 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AM4QR4KEBTGRIC7GD5YNHCLWC7KRLANCNFSM6AAAAAAQP4WWOU>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.