Skip to content

Commit a4de362

Browse files
authored
Merge pull request #208 from a1mery/ChartCard-FilesByContentType-1.21.1-upgrade
Upgrade ChartCard-FilesByContentType to SPFx 1.21.1
2 parents 6189419 + fda2011 commit a4de362

7 files changed

Lines changed: 7782 additions & 7200 deletions

File tree

samples/ChartCard-FilesByContentType/.eslintrc.js

Lines changed: 2 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require('@rushstack/eslint-config/patch/modern-module-resolution');
21
module.exports = {
32
extends: ['@microsoft/eslint-config-spfx/lib/profiles/default'],
43
parserOptions: { tsconfigRootDir: __dirname },
@@ -20,39 +19,6 @@ module.exports = {
2019
'@rushstack/security/no-unsafe-regexp': 1,
2120
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
2221
'@typescript-eslint/adjacent-overload-signatures': 1,
23-
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
24-
//
25-
// CONFIGURATION: By default, these are banned: String, Boolean, Number, Object, Symbol
26-
'@typescript-eslint/ban-types': [
27-
1,
28-
{
29-
'extendDefaults': false,
30-
'types': {
31-
'String': {
32-
'message': 'Use \'string\' instead',
33-
'fixWith': 'string'
34-
},
35-
'Boolean': {
36-
'message': 'Use \'boolean\' instead',
37-
'fixWith': 'boolean'
38-
},
39-
'Number': {
40-
'message': 'Use \'number\' instead',
41-
'fixWith': 'number'
42-
},
43-
'Object': {
44-
'message': 'Use \'object\' instead, or else define a proper TypeScript type:'
45-
},
46-
'Symbol': {
47-
'message': 'Use \'symbol\' instead',
48-
'fixWith': 'symbol'
49-
},
50-
'Function': {
51-
'message': 'The \'Function\' type accepts any function-like value.\nIt provides no type safety when calling the function, which can be a common source of bugs.\nIt also accepts things like class declarations, which will throw at runtime as they will not be called with \'new\'.\nIf you are expecting the function to accept certain arguments, you should explicitly define the function shape.'
52-
}
53-
}
54-
}
55-
],
5622
// RATIONALE: Code is more readable when the type of every variable is immediately obvious.
5723
// Even if the compiler may be able to infer a type, this inference will be unavailable
5824
// to a person who is reviewing a GitHub diff. This rule makes writing code harder,
@@ -79,7 +45,7 @@ module.exports = {
7945
// This rule should be suppressed only in very special cases such as JSON.stringify()
8046
// where the type really can be anything. Even if the type is flexible, another type
8147
// may be more appropriate such as "unknown", "{}", or "Record<k,V>".
82-
'@typescript-eslint/no-explicit-any': 1,
48+
'@typescript-eslint/no-explicit-any': 0,
8349
// RATIONALE: The #1 rule of promises is that every promise chain must be terminated by a catch()
8450
// handler. Thus wherever a Promise arises, the code must either append a catch handler,
8551
// or else return the object to a caller (who assumes this responsibility). Unterminated
@@ -298,7 +264,7 @@ module.exports = {
298264
'no-with': 2,
299265
// RATIONALE: Makes logic easier to understand, since constants always have a known value
300266
// @typescript-eslint\eslint-plugin\dist\configs\eslint-recommended.js
301-
'prefer-const': 1,
267+
'prefer-const': 0,
302268
// RATIONALE: Catches a common coding mistake where "resolve" and "reject" are confused.
303269
'promise/param-names': 2,
304270
// RATIONALE: Catches code that is likely to be incorrect

samples/ChartCard-FilesByContentType/.yo-rc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"@microsoft/microsoft-graph-client": "3.0.2",
88
"@microsoft/teams-js": "2.24.0"
99
},
10-
"version": "1.20.0-beta.0",
10+
"version": "1.21.1",
1111
"libraryName": "chart-card-files-by-content-type",
1212
"libraryId": "1ac895fb-8ac0-44ce-9b5a-61b9dba15ff4",
1313
"environment": "spo",

samples/ChartCard-FilesByContentType/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Medium view:
1515

1616
## Used SharePoint Framework Version
1717

18-
![version](https://img.shields.io/badge/version-1.20.0--beta.0-yellow.svg)
18+
![version](https://img.shields.io/badge/version-1.21.1-yellow.svg)
1919

2020
## Applies to
2121

@@ -38,6 +38,7 @@ Medium view:
3838
| Version | Date | Comments |
3939
| ------- | ---------------- | --------------- |
4040
| 1.0 | September 08, 2024 | Initial release |
41+
| 1.1 | October 29, 2025 | Upgrade to SPFx 1.21.1 |
4142

4243
## Disclaimer
4344

samples/ChartCard-FilesByContentType/config/package-solution.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"solution": {
44
"name": "chart-card-files-by-content-type-client-side-solution",
55
"id": "1ac895fb-8ac0-44ce-9b5a-61b9dba15ff4",
6-
"version": "1.0.0.0",
6+
"version": "1.1.0.0",
77
"includeClientSideAssets": true,
88
"skipFeatureDeployment": true,
99
"isDomainIsolated": false,

0 commit comments

Comments
 (0)