Added choice radio button handling

[GuidoZam]

Q	A
Bug fix?	[ ]
New feature?	[x]
New sample?	[ ]
Related issues?	fixes #1797

What's in this Pull Request?

Added handling of the choice field when set to radio button instead of dropdown.

[joelfmrodrigues]

@GuidoZam many thanks for the improvements. I reviewed it and all seems fine, but I will consider waiting for #1726 to avoid conflicts. If the other PR doesn't move forward quickly, I will then merge this PR first.

[GuidoZam]

Thanks @joelfmrodrigues for the update, I'll wait for the merge 😁

[IRRDC]

I just wrote the same feature and then I found this :-)
Is it going to be included in a release build soon?

[GuidoZam]

@IRRDC I think we're still waiting for the other PR.
@joelfmrodrigues do you have any news?

[joelfmrodrigues]

@GuidoZam hi, sorry I have been struggling to find time and was a bit away from things for personal reasons. Hope to get moving again soon

[GuidoZam]

Hope everything's fine @joelfmrodrigues!
I didn't want to rush you, I was just checking 😉

[IRRDC]

@GuidoZam I tested your code and would suggest that you remove these two lines:

since they lead to duplicate labels and make the field always required.
Before removing them:

After removing them:

[GuidoZam]

Thanks for the feedback @IRRDC!!
I've updated the code.

[michaelmaillot]

Hi Guido, would you mind updating your branch / PR regarding conflicts? Thanks.

[GuidoZam]

Hi @michaelmaillot, I've resolved the conflicts.

[michaelmaillot]

Thanks for the update!

I think you've missed the choiceType variable init during the PR's sync with dev branch here:

// Store the choice type for Choice fields
// This represent the format of the choice field (Dropdown or Radio Buttons)
choiceType = field.FormatType;

A few things to update and we should be fine.

[GuidoZam]

Hi @michaelmaillot, sorry for the late reply!
Thanks for the review, I've updated the PR accordingly, now it should be ready to go 🤞

[michaelmaillot]

Thanks for this update, a few changes and we'll be good!

[GuidoZam]

Hi @michaelmaillot I've updated accordingly to your latest suggestions.

[michaelmaillot]

Merged manually, thank you!