-
-
Notifications
You must be signed in to change notification settings - Fork 212
docs: Update README to include devEngines.packageManager #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,7 +12,7 @@ Install pnpm package manager. | |
|
|
||
| Version of pnpm to install. | ||
|
|
||
| **Optional** when there is a [`packageManager` field in the `package.json`](https://nodejs.org/api/corepack.html). | ||
| **Optional** when there is a [`packageManager` or `devEngines.packageManager` field in the `package.json`](https://nodejs.org/api/corepack.html). | ||
|
|
||
| otherwise, this field is **required** It supports npm versioning scheme, it could be an exact version (such as `10.9.8`), or a version range (such as `10`, `10.x.x`, `10.9.x`, `^10.9.8`, `*`, etc.), or `latest`. | ||
|
|
||
|
|
@@ -52,7 +52,7 @@ If `run_install` is a YAML string representation of either an object or an array | |
|
|
||
| ### `package_json_file` | ||
|
|
||
| **Optional** (_type:_ `string`, _default:_ `package.json`) File path to the `package.json`/[`package.yaml`](https://github.com/pnpm/pnpm/pull/1799) to read "packageManager" configuration. | ||
| **Optional** (_type:_ `string`, _default:_ `package.json`) File path to the `package.json`/[`package.yaml`](https://github.com/pnpm/pnpm/pull/1799) to read `packageManager` or `devEngines.packageManager` configuration. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is desired. Explicit vs implicit. Nothing wrong with having it. |
||
|
|
||
| ### `standalone` | ||
|
|
||
|
|
@@ -74,7 +74,7 @@ Location of `pnpm` and `pnpx` command. | |
|
|
||
| ### Install only pnpm without `packageManager` | ||
|
|
||
| This works when the repo either doesn't have a `package.json` or has a `package.json` but it doesn't specify `packageManager`. | ||
| This works when the repo either doesn't have a `package.json` or has a `package.json` but it doesn't specify `packageManager` or `devEngines.packageManager`. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As with the above comment, this is a matter of explicit vs implicit. Nothing wrong with this change if it's desired. |
||
|
|
||
| ```yaml | ||
| on: | ||
|
|
@@ -93,7 +93,7 @@ jobs: | |
|
|
||
| ### Install only pnpm with `packageManager` | ||
|
|
||
| Omit `version` input to use the version in the [`packageManager` field in the `package.json`](https://nodejs.org/api/corepack.html). | ||
| Omit `version` input to use the version in the [`packageManager` or `devEngines.packageManager` field in the `package.json`](https://nodejs.org/api/corepack.html). | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More explicit vs implicit. Same as above comments. |
||
|
|
||
| ```yaml | ||
| on: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.