feat: support pnpm v11 and allowBuilds (#3)

Author: zkochan

pnpmfile.cjs

@@ -1,17 +1,30 @@
 module.exports = {
   hooks: {
     updateConfig (config) {
-      if (config.onlyBuiltDependencies == null) {
-        config.onlyBuiltDependencies = []
-      }
+      const pnpmMajor = parseInt(config.packageManager?.version?.split('.')[0] ?? '0', 10)
+      const useAllowBuilds = pnpmMajor >= 11
       const defaultAllowed = require('./allow.json')
-      if (!config.ignoredBuiltDependencies?.length) {
-        config.onlyBuiltDependencies.push(...defaultAllowed)
-      } else {
-        const ignored = new Set(config.ignoredBuiltDependencies)
+      if (useAllowBuilds) {
+        if (config.allowBuilds == null) {
+          config.allowBuilds = {}
+        }
         for (const allowed of defaultAllowed) {
-          if (!ignored.has(allowed)) {
-            config.onlyBuiltDependencies.push(allowed)
+          if (config.allowBuilds[allowed] == null) {
+            config.allowBuilds[allowed] = true
+          }
+        }
+      } else {
+        if (config.onlyBuiltDependencies == null) {
+          config.onlyBuiltDependencies = []
+        }
+        if (!config.ignoredBuiltDependencies?.length) {
+          config.onlyBuiltDependencies.push(...defaultAllowed)
+        } else {
+          const ignored = new Set(config.ignoredBuiltDependencies)
+          for (const allowed of defaultAllowed) {
+            if (!ignored.has(allowed)) {
+              config.onlyBuiltDependencies.push(allowed)
+            }
           }
         }
       }

test.js

@@ -8,11 +8,42 @@ test('TRUSTED_PACKAGE_NAMES', () => {
   assert.equal(typeof TRUSTED_PACKAGE_NAMES[0], 'string')
 })
 
-test('do not reenable dependency builds', () => {
+test('populates onlyBuiltDependencies for pnpm < 11', () => {
   const config = {
+    packageManager: { version: '10.28.1' },
+  }
+  pnpmfile.hooks.updateConfig(config)
+  assert(config.onlyBuiltDependencies.includes('@apollo/rover'))
+  assert.equal(config.allowBuilds, undefined)
+})
+
+test('do not reenable dependency builds for pnpm < 11', () => {
+  const config = {
+    packageManager: { version: '10.28.1' },
     ignoredBuiltDependencies: ['esbuild'],
   }
   pnpmfile.hooks.updateConfig(config)
   assert(!config.onlyBuiltDependencies.includes('esbuild'))
   assert(config.onlyBuiltDependencies.includes('@apollo/rover'))
 })
+
+test('populates allowBuilds for pnpm >= 11', () => {
+  const config = {
+    packageManager: { version: '11.0.0' },
+  }
+  pnpmfile.hooks.updateConfig(config)
+  assert.equal(typeof config.allowBuilds, 'object')
+  assert(!Array.isArray(config.allowBuilds))
+  assert.equal(config.allowBuilds['@apollo/rover'], true)
+  assert.equal(config.onlyBuiltDependencies, undefined)
+})
+
+test('do not reenable dependency builds for pnpm >= 11', () => {
+  const config = {
+    packageManager: { version: '11.0.0' },
+    allowBuilds: { esbuild: false },
+  }
+  pnpmfile.hooks.updateConfig(config)
+  assert.equal(config.allowBuilds.esbuild, false)
+  assert.equal(config.allowBuilds['@apollo/rover'], true)
+})