Skip to content

Change base image in Dockerfile examples to Node.js 24#799

Open
Mister-Hope wants to merge 1 commit into
pnpm:mainfrom
Mister-Hope:patch-18
Open

Change base image in Dockerfile examples to Node.js 24#799
Mister-Hope wants to merge 1 commit into
pnpm:mainfrom
Mister-Hope:patch-18

Conversation

@Mister-Hope
Copy link
Copy Markdown
Contributor

@Mister-Hope Mister-Hope commented May 15, 2026

Updated Dockerfile examples to use Node.js 24 instead of 20.

pnpm can no longer run on 24 with v11

Summary by CodeRabbit

  • Documentation
    • Updated Docker examples to use Node.js 24 instead of Node.js 20 in CLI documentation.

Review Change Stack

Updated Dockerfile examples to use Node.js 24 instead of 20.

pnpm can no longer run on 24 with v11
Copilot AI review requested due to automatic review settings May 15, 2026 03:36
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 15, 2026

@Mister-Hope is attempting to deploy a commit to the pnpm Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1505b861-547d-4c67-91c4-a3598c8cff99

📥 Commits

Reviewing files that changed from the base of the PR and between c5ad823 and 1cb4f90.

📒 Files selected for processing (1)
  • docs/cli/fetch.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: deploy
🔇 Additional comments (1)
docs/cli/fetch.md (1)

19-19: ⚡ Quick win

No action needed—Node.js 24 is supported by pnpm v11.

According to official pnpm documentation, pnpm v11 supports Node.js versions 22, 24, and 26. The Docker examples in this PR are correct as written. Official pnpm Docker examples also use node:24-slim with pnpm v11, confirming the compatibility.

			> Likely an incorrect or invalid review comment.

📝 Walkthrough

Walkthrough

Updated Dockerfile base image examples in the fetch command documentation from Node.js 20 to Node.js 24. All three Dockerfile snippets across the single-project, monorepo, and pnpm fetch examples are synchronized to the newer base image tag.

Changes

Documentation updates

Layer / File(s) Summary
Dockerfile examples node version bump
docs/cli/fetch.md
Dockerfile examples in the fetch command documentation are updated to use FROM node:24 instead of FROM node:20 across three example snippets: single-project, monorepo, and pnpm fetch examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • pnpm/pnpm.io#771: Updates Dockerfile examples from Node.js 20 to Node.js 24 in a different documentation file.

Suggested reviewers

  • zkochan

Poem

🐰 From twenty to twenty-four, the Docker base takes flight,
With nimble paws we've patched each example bright!
Three snippets spruced, one file made new,
Node.js versions polished through and through. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating Dockerfile examples from Node.js 20 to Node.js 24, which is the primary modification across all three affected examples.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Node.js base image version in Dockerfile examples within the pnpm fetch CLI documentation from Node.js 20 to Node.js 24, since pnpm v11 can no longer run on Node.js 20.

Changes:

  • Replaces three FROM node:20 references with FROM node:24 in Dockerfile code blocks within the fetch documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants