Address code review feedback: extract magic numbers to constants

Co-authored-by: npv2k1 <73846954+npv2k1@users.noreply.github.com>

Author: Copilot

src/components/mod.rs

@@ -6,6 +6,8 @@
 use bevy::prelude::*;
 use serde::{Deserialize, Serialize};
 
+use crate::game::constants::camera::{MAX_SMOOTHING, MIN_SMOOTHING};
+
 /// Marker component for the player entity
 #[derive(Component, Debug, Default)]
 pub struct Player;
@@ -210,7 +212,7 @@ impl CameraFollow {
     }
 
     pub fn with_smoothing(mut self, smoothing: f32) -> Self {
-        self.smoothing = smoothing.clamp(0.01, 1.0);
+        self.smoothing = smoothing.clamp(MIN_SMOOTHING, MAX_SMOOTHING);
         self
     }
 }

src/game/mod.rs

@@ -11,4 +11,44 @@ pub mod constants {
     pub const WINDOW_HEIGHT: f32 = 720.0;
     /// Game title
     pub const GAME_TITLE: &str = "2D Mario-Style Platformer";
+
+    /// Camera smoothing constants
+    pub mod camera {
+        /// Target framerate for smoothing calculations
+        pub const TARGET_FRAMERATE: f32 = 60.0;
+        /// Minimum smoothing factor (instant follow)
+        pub const MIN_SMOOTHING: f32 = 0.01;
+        /// Maximum smoothing factor (slowest follow)
+        pub const MAX_SMOOTHING: f32 = 1.0;
+    }
+
+    /// Obstacle spawning constants
+    pub mod obstacles {
+        /// X position where obstacles spawn (right side of screen)
+        pub const SPAWN_X: f32 = 700.0;
+        /// Minimum Y position for obstacle spawn
+        pub const SPAWN_Y_MIN: f32 = -200.0;
+        /// Maximum Y position for obstacle spawn
+        pub const SPAWN_Y_MAX: f32 = 150.0;
+        /// Minimum obstacle width
+        pub const WIDTH_MIN: f32 = 30.0;
+        /// Maximum obstacle width
+        pub const WIDTH_MAX: f32 = 60.0;
+        /// Minimum obstacle height
+        pub const HEIGHT_MIN: f32 = 30.0;
+        /// Maximum obstacle height
+        pub const HEIGHT_MAX: f32 = 60.0;
+        /// Minimum obstacle speed
+        pub const SPEED_MIN: f32 = 100.0;
+        /// Maximum obstacle speed
+        pub const SPEED_MAX: f32 = 250.0;
+        /// X position at which obstacles are despawned (left side of screen)
+        pub const DESPAWN_X: f32 = -800.0;
+    }
+
+    /// Scoring constants
+    pub mod scoring {
+        /// Points awarded for surviving obstacle collision
+        pub const OBSTACLE_SURVIVE_POINTS: u32 = 10;
+    }
 }

src/systems/camera.rs

@@ -3,6 +3,7 @@
 use bevy::prelude::*;
 
 use crate::components::{CameraFollow, MainCamera, Player};
+use crate::game::constants::camera::TARGET_FRAMERATE;
 
 /// Updates camera to follow the target entity smoothly
 pub fn camera_follow_system(
@@ -17,8 +18,11 @@ pub fn camera_follow_system(
     for (mut camera_transform, camera_follow) in camera_query.iter_mut() {
         let target_position = player_transform.translation + camera_follow.offset;
 
-        // Smooth camera movement using lerp
-        let lerp_factor = 1.0 - camera_follow.smoothing.powf(time.delta_seconds() * 60.0);
+        // Smooth camera movement using lerp (frame-rate independent)
+        let lerp_factor = 1.0
+            - camera_follow
+                .smoothing
+                .powf(time.delta_seconds() * TARGET_FRAMERATE);
         camera_transform.translation.x = camera_transform
             .translation
             .x

src/systems/collision.rs

@@ -3,6 +3,7 @@
 use bevy::prelude::*;
 
 use crate::components::{BoxCollider, DamageOnContact, Health, Obstacle, Player};
+use crate::game::constants::scoring::OBSTACLE_SURVIVE_POINTS;
 use crate::resources::Score;
 
 /// Checks for collisions between player and obstacles
@@ -50,8 +51,8 @@ pub fn check_obstacle_collisions(
             // Remove the obstacle
             commands.entity(obstacle_entity).despawn();
 
-            // Add score for surviving
-            score.add(10);
+            // Add score for surviving collision
+            score.add(OBSTACLE_SURVIVE_POINTS);
         }
     }
 }

src/systems/obstacle.rs

@@ -4,6 +4,10 @@ use bevy::prelude::*;
 use rand::Rng;
 
 use crate::components::{AutoMove, BoxCollider, DamageOnContact, Obstacle};
+use crate::game::constants::obstacles::{
+    DESPAWN_X, HEIGHT_MAX, HEIGHT_MIN, SPAWN_X, SPAWN_Y_MAX, SPAWN_Y_MIN, SPEED_MAX, SPEED_MIN,
+    WIDTH_MAX, WIDTH_MIN,
+};
 use crate::resources::ObstacleSpawnTimer;
 
 /// Spawns obstacles at regular intervals
@@ -18,15 +22,15 @@ pub fn spawn_obstacles(
         let mut rng = rand::thread_rng();
 
         // Random spawn position on the right side of the screen
-        let spawn_x = 700.0;
-        let spawn_y = rng.gen_range(-200.0..150.0);
+        let spawn_x = SPAWN_X;
+        let spawn_y = rng.gen_range(SPAWN_Y_MIN..SPAWN_Y_MAX);
 
         // Random obstacle size
-        let width = rng.gen_range(30.0..60.0);
-        let height = rng.gen_range(30.0..60.0);
+        let width = rng.gen_range(WIDTH_MIN..WIDTH_MAX);
+        let height = rng.gen_range(HEIGHT_MIN..HEIGHT_MAX);
 
         // Random speed
-        let speed = rng.gen_range(100.0..250.0);
+        let speed = rng.gen_range(SPEED_MIN..SPEED_MAX);
 
         commands.spawn((
             Obstacle,
@@ -53,7 +57,7 @@ pub fn despawn_offscreen_obstacles(
 ) {
     for (entity, transform) in query.iter() {
         // Despawn if too far left
-        if transform.translation.x < -800.0 {
+        if transform.translation.x < DESPAWN_X {
             commands.entity(entity).despawn();
         }
     }