Skip to content

Cooldown update process for dependencies #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Sep 18, 2025
Merged

Cooldown update process for dependencies #677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ updates:
directory: /
schedule:
interval: daily
cooldown:
default-days: 1

@amazon-q-developer amazon-q-developer Bot Sep 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

セキュリティの観点から、GitHub Actionsの依存関係にもcooldown期間を設定するのは慎重すぎる可能性があります。GitHub Actionsのセキュリティアップデートは迅速に適用すべきです。セキュリティ関連の更新を除外する設定を検討してください。

groups:
actions:
patterns:
Expand All @@ -15,6 +17,10 @@ updates:
- /test/
schedule:
interval: daily
cooldown:
default-days: 1
exclude:

@amazon-q-developer amazon-q-developer Bot Sep 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependabotの設定にcooldown機能を追加したのは良い改善です。ただし、npm依存関係の設定でexcludeにpnpmを指定していますが、これはpnpm-workspace.yamlのminimumReleaseAgeExclude設定と重複しています。設定の一貫性を保つため、どちらか一方で管理することを推奨します。

- 'pnpm'
groups:
npm:
patterns:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@
"typescript": "^5.9.2",
"typescript-eslint": "^8.44.0"
},
"packageManager": "pnpm@10.16.1"
"packageManager": "pnpm@10.17.0"

@amazon-q-developer amazon-q-developer Bot Sep 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpmのバージョンを10.16.1から10.17.0にアップデートしていますが、この変更はpnpm-workspace.yamlのminimumReleaseAgeExclude設定と一致しています。セキュリティ上の理由でpnpmを除外対象にしているのは適切な判断です。

}
6 changes: 6 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,9 @@ packages:

enablePrePostScripts: true
strictPeerDependencies: false

# one day
minimumReleaseAge: 1440
minimumReleaseAgeExclude:
- pnpm
- appstore-connect-jwt-generator-core
Comment on lines +8 to +12

@amazon-q-developer amazon-q-developer Bot Sep 18, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新しく追加されたminimumReleaseAge設定は依存関係の更新を制御する良いアプローチです。1440分（1日）のクールダウン期間は適切です。ただし、appstore-connect-jwt-generator-coreを除外対象に含めている理由が不明です。このパッケージが頻繁に更新される必要がある特別な理由があるでしょうか？コメントで説明を追加することを推奨します。

Suggested change
# one day
minimumReleaseAge: 1440
minimumReleaseAgeExclude:
- pnpm
- appstore-connect-jwt-generator-core
# one day cooldown for dependency updates to ensure stability
minimumReleaseAge: 1440
minimumReleaseAgeExclude:
- pnpm # Package manager updates should be applied quickly for security
- appstore-connect-jwt-generator-core # Core library requiring immediate updates