Skip to content

Fix the typing #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Nov 2, 2025
Merged

Fix the typing #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ cdk.out

.DS_Store
*.map
*.tgz
package
Comment on lines +12 to +13

@amazon-q-developer amazon-q-developer Bot Nov 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore への *.tgz と package の追加は適切です。これらはnpmパッケージのビルド成果物やテスト用のパッケージファイルであり、バージョン管理から除外すべきファイルです。パッケージ開発時の一時的なファイルが誤ってコミットされることを防げます。

12 changes: 10 additions & 2 deletions package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,27 @@
],
"private": false,
"sideEffects": false,
"files": [
"dist",
"README.md"
],
Comment on lines +14 to +17

@amazon-q-developer amazon-q-developer Bot Nov 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

パッケージ公開時に含まれるファイルを明示的に指定する files フィールドの追加は良い改善です。ただし、TypeScriptプロジェクトでは型定義ファイル（*.d.ts）も含めることを推奨します。また、package.json 自体も含めることが一般的です。

Suggested change
"files": [
"dist",
"README.md"
],
"files": [
"dist",
"README.md",
"package.json"
],

"homepage": "https://github.com/poad/aws-lambda-mcp-server#readme",
"repository": {
"type": "git",
"url": "git+https://github.com/poad/aws-lambda-mcp-server.git"
},
"publishConfig": {
"main": "./dist/index.js",
"typings": "./dist/index.d.ts"
},
Comment on lines +23 to +26

@amazon-q-developer amazon-q-developer Bot Nov 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

パッケージの公開設定が適切に改善されています。files フィールドの追加により、公開時に必要なファイルのみが含まれるようになり、publishConfig の追加により型解決の問題が解決されます。ただし、publishConfig の typings フィールドは非推奨のため、types を使用することを推奨します。

Suggested change
"publishConfig": {
"main": "./dist/index.js",
"typings": "./dist/index.d.ts"
},
"publishConfig": {
"main": "./dist/index.js",
"types": "./dist/index.d.ts"
},

"exports": {
".": {
"types": "./dist/index.d.ts",
"default": "./dist/index.js"
}
},
"module": "./dist/index.js",
"types": "dist/index.d.ts",
"types": "./dist/index.d.ts",
"main": "./dist/index.js",
"author": "poad",
"license": "ISC",
Expand Down Expand Up @@ -56,4 +64,4 @@
"hono": "^4.10.4",
"zod": "^3.25.76"
}
}
}

@amazon-q-developer amazon-q-developer Bot Nov 2, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ファイル末尾の改行が削除されています。JSONファイルでは必須ではありませんが、多くのエディタやlintツールが末尾の改行を期待するため、一貫性のために追加することを推奨します。

Suggested change
}
}