Support quoted parameters and URI syntax in PostgreSQL connection strings#5346
Merged
Conversation
matejk
reviewed
May 11, 2026
matejk
left a comment
matejk
left a comment
Contributor
There was a problem hiding this comment.
Review combining clang-tidy 21 (focused on PR-changed lines), an independent code-reviewer agent, CodeRabbit CLI 0.4.5, and empirical libpq probing.
One critical finding (silent corruption of postgres:// URI connection strings -- see inline on SessionImpl.cpp L110), one important test-coverage gap, and several minor style/correctness suggestions inline.
Thanks for taking this on -- moving from the home-grown parser to libpq is the right call, and URI support is a welcome addition.
Contributor
Author
|
@matejk I've implemented the changes based on your review comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently POCO parses PostgreSQL connection strings itself and doesn't support quoted parameters with spaces as described in https://www.postgresql.org/docs/current/libpq-connect.html#LIBPQ-CONNSTRING
This PR uses libpq to parse connection strings and also supports URI syntax.