chore(ci): add Linux make build sanity job#5364
Merged
Merged
Conversation
The classic ./configure + make build is no longer officially supported, but several embedded and legacy environments still rely on it. Add a Linux build-only probe that exercises the make path with --everything so any breakage in the configure script, build/config or per-component Makefiles surfaces in CI. Tests are compiled (TESTS=1) but not executed -- the cmake jobs above already cover the runtime signal. Samples are skipped to keep the wall-clock reasonable.
OpenSSLInitializerTest.{cpp,h} were added in #5246 and registered in
CryptoTestSuite, but the classic make testsuite Makefile lists sources
explicitly and was never updated. CMake's file(GLOB) hid the gap. The
new Linux make CI job exposes it as a link-time undefined reference.
unixODBC's testsuite link pulls in libltdl for dynamic driver loading, matching the historical pre-cmake CI install list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a build-only CI job that exercises the classic
./configure + makepath on Linux. Make is no longer officially supported but is still used by several embedded and legacy environments, and keeping a sanity build in CI prevents silent regressions in theconfigurescript,build/config/Linux*files and per-component Makefiles.linux-gcc-make-buildonubuntu-24.04, gated onci_core/ push / manual dispatch../configure --everything --no-samplesbuilds all 24 standard components (Foundation, Encodings, XML, JSON, Util, Net, Crypto, NetSSL_OpenSSL, Data + SQLite/ODBC/MySQL/PostgreSQL, ActiveRecord (+ Compiler), Zip, JWT, PageCompiler (+ File2Page), CppParser, PDF, MongoDB, Redis, Prometheus).make -s -j$(nproc)builds libs and testsuites (TESTS=1 from configure); samples and test execution are skipped -- the existing cmake jobs already cover the runtime signal.libssl-dev unixodbc-dev libmysqlclient-dev libpq-devso Crypto/NetSSL and the four Data backends link cleanly.Test plan
linux-gcc-make-buildjob is scheduled and goes green.libPocoFoundation.soand one testrunner binary (e.g.Foundation-testrunner) for at least one component.