ci: add check for job dependencies

Because merge protection gates on Total Success we should have a job to
ensure the yaml really has the right deps for it to work correctly.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Author: Luap99

.github/workflows/ci.yml

@@ -153,6 +153,7 @@ jobs:
     name: "Total Success"
     if: always()
     needs:
+      - path-filter
       - validate
       - storage-test
       - storage-cross

.github/workflows/validate.yml

@@ -9,7 +9,7 @@ env:
   LINT_VERSION: v2.12.2
 
 jobs:
-  codespell:
+  basic:
     runs-on: ubuntu-24.04
     steps:
     - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
@@ -18,6 +18,8 @@ jobs:
       run: pip install --break-system-packages codespell==v2.4.1
     - name: run codespell
       run: make codespell
+    - name: check-ci-yaml
+      run: make check-ci-yaml
 
   lint:
     runs-on: ubuntu-24.04

Makefile

@@ -11,7 +11,11 @@ export PATH := $(PATH):${GOBIN}
 EPOCH_TEST_COMMIT ?= $(shell git merge-base $${DEST_BRANCH:-main} HEAD)
 
 
-validate: codespell git-validation lint
+validate: codespell git-validation lint check-ci-yaml
+
+.PHONY: check-ci-yaml
+check-ci-yaml:
+	hack/ci/ci_yaml_test.py
 
 .PHONY: codespell
 codespell:

hack/ci/ci_yaml_test.py

@@ -0,0 +1,42 @@
+#!/usr/bin/env python3
+
+"""
+Verify contents of .github/workflows/ci.yml meet specific expectations
+"""
+
+import sys
+import os
+import unittest
+import yaml
+
+# Assumes directory structure of this file relative to repo.
+SCRIPT_DIRPATH = os.path.dirname(os.path.realpath(__file__))
+REPO_ROOT = os.path.realpath(os.path.join(SCRIPT_DIRPATH, '../', '../'))
+
+
+class TestCaseBase(unittest.TestCase):
+
+    CI_YAML = None
+
+    def setUp(self):
+        with open(os.path.join(REPO_ROOT, '.github/workflows/ci.yml')) as ci_yaml:
+            self.CI_YAML = yaml.safe_load(ci_yaml.read())
+
+
+class TestDependsOn(TestCaseBase):
+
+    ALL_TASK_NAMES = None
+
+    def setUp(self):
+        super().setUp()
+        self.ALL_TASK_NAMES = list(self.CI_YAML['jobs'].keys())
+
+
+    def test_success_deps(self):
+        """Specific success task depends on all others"""
+        all_tasks = self.ALL_TASK_NAMES.remove('success')
+        needs = self.CI_YAML['jobs']['success']['needs']
+        self.assertCountEqual(needs, self.ALL_TASK_NAMES)
+
+if __name__ == "__main__":
+    unittest.main()