storage: use -json parameter for system_profiler SPSoftwareDataType#993
Open
marie wants to merge 1 commit into
Open
storage: use -json parameter for system_profiler SPSoftwareDataType#993marie wants to merge 1 commit into
system_profiler SPSoftwareDataType#993marie wants to merge 1 commit into
Conversation
mtrmac
reviewed
Jul 20, 2026
| func getRelease() (string, error) { | ||
| cmd := exec.Command("system_profiler", "SPSoftwareDataType") | ||
| osName, err := cmd.Output() | ||
| cmd := exec.Command("system_profiler", "SPSoftwareDataType", "-json") |
Contributor
There was a problem hiding this comment.
The man page documents [-json] dataType1 ... dataTypeN; I agree putting -json at the end currently works, but given the BSD tradition it might be a tiny bit safer to put it first.
| } | ||
| var result struct { | ||
| SPSoftwareDataType []struct { | ||
| KernelVersion string `json:"kernel_version"` |
Contributor
There was a problem hiding this comment.
Given encoding/json/v2.RejectUnknownMembers landing in Go 1.27, it might help future maintainers to add a comment that this contains other fields which we ignore, to ensure RejectUnknownMembers is not used in the future.
Removes go-shellwords dependency from kernel_darwin.go Fixes: podman-container-tools#983 Signed-off-by: Maria Glushenok <glushenokm@gmail.com>
marie
force-pushed
the
use-json-sys-profiler
branch
from
July 21, 2026 16:26
d670c0b to
9bdc786
Compare
Author
|
@mtrmac I've fixed the problems you mentioned. Could you review it one more time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
system_profiler SPSoftwareDataTypecommand to use the-jsonflag. This allows the system to parse OS information without the externalgo-shellwordslibrary.Fixes: #983