Merge branch 'main' into xcode-26-4

Author: stephencelis

Sources/SQLiteData/CloudKit/Internal/DataManager.swift

@@ -77,7 +77,7 @@
     }
 
     package var temporaryDirectory: URL {
-      URL(fileURLWithPath: "/")
+      URL(fileURLWithPath: "/tmp")
     }
   }
 
@@ -86,6 +86,9 @@
     static var liveValue: any DataManager {
       LiveDataManager()
     }
+    static var previewValue: any DataManager {
+      InMemoryDataManager()
+    }
     static var testValue: any DataManager {
       InMemoryDataManager()
     }

Sources/SQLiteData/CloudKit/Internal/MockCloudDatabase.swift

@@ -60,7 +60,7 @@
         for key in record.allKeys() {
           guard let assetData = state.assets[AssetID(recordID: record.recordID, key: key)]
           else { continue }
-          let url = URL(filePath: UUID().uuidString.lowercased())
+          let url = dataManager.wrappedValue.temporaryDirectory.appending(path: UUID().uuidString)
           try dataManager.wrappedValue.save(assetData, to: url)
           record[key] = CKAsset(fileURL: url)
         }

Sources/SQLiteData/CloudKit/SyncEngine.swift

@@ -106,7 +106,7 @@
       let containerIdentifier =
         containerIdentifier
         ?? ModelConfiguration(groupContainer: .automatic).cloudKitContainerIdentifier
-        ?? (context == .preview ? "preview" : nil)
+        ?? (context != .live ? "container" : nil)
       var allTables: [any SynchronizableTable] = []
       var allPrivateTables: [any SynchronizableTable] = []
       for table in repeat each tables {
@@ -2169,15 +2169,19 @@
     package var `private`: (any SyncEngineProtocol)? {
       guard let `private` = rawValue?.private
       else {
-        reportIssue("Private sync engine has not been set.")
+        if isRunning {
+          reportIssue("Private sync engine has not been set.")
+        }
         return nil
       }
       return `private`
     }
     package var `shared`: (any SyncEngineProtocol)? {
       guard let `shared` = rawValue?.shared
       else {
-        reportIssue("Shared sync engine has not been set.")
+        if isRunning {
+          reportIssue("Shared sync engine has not been set.")
+        }
         return nil
       }
       return `shared`
@@ -2214,7 +2218,7 @@
       let containerIdentifier =
         containerIdentifier
         ?? ModelConfiguration(groupContainer: .automatic).cloudKitContainerIdentifier
-        ?? (context == .preview ? "preview" : nil)
+        ?? (context != .live ? "container" : nil)
 
       guard let containerIdentifier else {
         throw SyncEngine.SchemaError.noCloudKitContainer
@@ -2243,7 +2247,7 @@
         url.isInMemory
         ? try DatabaseQueue(path: path)
         : try DatabasePool(path: path)
-      _ = try database.write { db in
+      _ = try database.read { db in
         try #sql("SELECT 1").execute(db)
       }
       try #sql(

Tests/SQLiteDataTests/CloudKitTests/AppLifecycleTests.swift

@@ -51,6 +51,15 @@
         }
       }
 
+      @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
+      @Test(.startImmediately(false))
+      func background_whileNotRunning() async throws {
+        defaultNotificationCenter.post(
+          name: UIApplication.willResignActiveNotification, object: nil)
+        try await Task.sleep(for: .seconds(1))
+        // NB: Not runtime warnings emitted.
+      }
+
       @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
       @Test func sendSharedChanges() async throws {
         let externalZone = CKRecordZone(

Tests/SQLiteDataTests/CloudKitTests/AssetsTests.swift

@@ -37,7 +37,7 @@
                   coverImage_hash: Data(32 bytes),
                   remindersListID: 1,
                   coverImage: CKAsset(
-                    fileURL: URL(file:///6105d6cc76af400325e94d588ce511be5bfdbb73b437dc51eca43917d7a43e3d),
+                    fileURL: URL(file:///tmp/6105d6cc76af400325e94d588ce511be5bfdbb73b437dc51eca43917d7a43e3d),
                     dataString: "image"
                   )
                 ),
@@ -61,7 +61,7 @@
 
         inMemoryDataManager.storage.withValue { storage in
           let url = URL(
-            string: "file:///6105d6cc76af400325e94d588ce511be5bfdbb73b437dc51eca43917d7a43e3d"
+            string: "file:///tmp/6105d6cc76af400325e94d588ce511be5bfdbb73b437dc51eca43917d7a43e3d"
           )!
           #expect(storage[url] == Data("image".utf8))
         }
@@ -93,7 +93,7 @@
                   coverImage_hash: Data(32 bytes),
                   remindersListID: 1,
                   coverImage: CKAsset(
-                    fileURL: URL(file:///97e67a5645969953f1a4cfe2ea75649864ff99789189cdd3f6db03e59f8a8ebf),
+                    fileURL: URL(file:///tmp/97e67a5645969953f1a4cfe2ea75649864ff99789189cdd3f6db03e59f8a8ebf),
                     dataString: "new-image"
                   )
                 ),
@@ -117,7 +117,7 @@
 
         inMemoryDataManager.storage.withValue { storage in
           let url = URL(
-            string: "file:///97e67a5645969953f1a4cfe2ea75649864ff99789189cdd3f6db03e59f8a8ebf"
+            string: "file:///tmp/97e67a5645969953f1a4cfe2ea75649864ff99789189cdd3f6db03e59f8a8ebf"
           )!
           #expect(storage[url] == Data("new-image".utf8))
         }

Tests/SQLiteDataTests/CloudKitTests/MockCloudDatabaseTests.swift

@@ -46,6 +46,30 @@
         #expect(error == CKError(.unknownItem))
       }
 
+      @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
+      @Test func assetsUseTemporaryDirectory() async throws {
+        let recordID = CKRecord.ID(recordName: "record")
+        let record = CKRecord(recordType: "Record", recordID: recordID)
+        let sourceURL = URL(fileURLWithPath: "/sqlite-data-test-assets/asset.jpg")
+        try inMemoryDataManager.save(Data("image".utf8), to: sourceURL)
+        record["asset"] = CKAsset(fileURL: sourceURL)
+
+        let database = syncEngine.private.database
+        let (saveResults, _) = try database.modifyRecords(
+          saving: [record],
+          deleting: []
+        )
+        _ = try saveResults[recordID]?.get()
+
+        let fetched = try database.record(for: recordID)
+        let asset = fetched["asset"] as? CKAsset
+        let assetDirectory = try #require(asset?.fileURL?.path())
+        #expect(
+          assetDirectory
+            .hasPrefix(inMemoryDataManager.temporaryDirectory.path())
+        )
+      }
+
       @available(iOS 17, macOS 14, tvOS 17, watchOS 10, *)
       @Test func saveTransaction_ChildBeforeParent() async throws {
         let parent = CKRecord(recordType: "A", recordID: CKRecord.ID(recordName: "A"))