Fetch current record before sharing.#363
Merged
Merged
Conversation
mbrandonw
commented
Jan 9, 2026
Comment on lines
+193
to
+203
| // NB: "Touch" parent records when saving a child: | ||
| if let parent = recordToSave.parent, | ||
| // If the parent isn't also being saved in this batch. | ||
| !recordsToSave.contains(where: { $0.recordID == parent.recordID }), | ||
| // And if the parent is in the database. | ||
| let parentRecord = storage[parent.recordID.zoneID]?.records[parent.recordID]?.copy() | ||
| as? CKRecord | ||
| { | ||
| parentRecord._recordChangeTag = UUID().uuidString | ||
| storage[parent.recordID.zoneID]?.records[parent.recordID] = parentRecord | ||
| } |
Member
Author
There was a problem hiding this comment.
This makes the mock cloud database behave more like CloudKit. And this change alone made some tests fail.
| * Create parent record and synchronize. | ||
| * Create child record and synchronize. | ||
| * Share parent record. | ||
| * See: https://github.com/pointfreeco/sqlite-data/pull/363 |
Member
There was a problem hiding this comment.
Should we start using @Test(.bug("<url>")) to track this kind of thing?
stephencelis
approved these changes
Jan 12, 2026
doozMen
pushed a commit
to doozMen/sqlite-data
that referenced
this pull request
Jan 22, 2026
* Fetch current record before sharing. * add an explicit test * wip * Move bug url to bug trait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a "quirk" (maybe bug?) in CloudKit where saving a child record will cause iCloud to update the parent's
recordChangeTag(this part is documented), but that update does not get sent to theCKSyncEngine(not documented, possible bug). This can cause us to have a stalelastKnownServerRecord, which can cause updates to the parent record to fail. Most of the time that is handled just fine by the conflict resolution mechanism in the library, but when sharing in particular we have to handle the situation more delicately. So now we make sure to fetch the freshest record from iCloud before sharing.