Skip to content

fix linux build by importing GRDBSQLite#41

Merged
stephencelis merged 1 commit into
pointfreeco:mainfrom
untitled-in-brackets:feature/linux-build
Apr 29, 2025
Merged

fix linux build by importing GRDBSQLite#41
stephencelis merged 1 commit into
pointfreeco:mainfrom
untitled-in-brackets:feature/linux-build

Conversation

@diederich
Copy link
Copy Markdown
Contributor

@diederich diederich commented Apr 29, 2025

I saw that the linux build failed and wondered if we should rely on the GRDBSQLite module instead of raw SQLite3.
From what I understand, that should resolve to SQLite3 on Darwin, but use libsqlite3 on Linux.

Also, I copied over the Linux pieces from swift-sharing & added installing sqlite.

Let me know what you think & happy to adjust!

saw that the linux build failed and wondered if we
should rely on the GRDBSQLite package instead of raw SQLite3.

From what I understand, that should resolve to SQLite3 on Darwin,
but use libsqlite3 on Linux.

Also copied over the Linux pieces from [swift-sharing](https://github.com/pointfreeco/swift-sharing/blob/main/.github/workflows/ci.yml)
+ installing sqlite
Copy link
Copy Markdown
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephencelis stephencelis merged commit 16c6f5e into pointfreeco:main Apr 29, 2025
3 checks passed
mbrandonw pushed a commit that referenced this pull request Aug 4, 2025
Derive metadatabase URL from database URL
mackoj pushed a commit to mackoj/sqlite-data that referenced this pull request Dec 5, 2025
* Add important note about safe SQL strings

We should stress against using `SELECT *` and referring to table/column
names using strings.

* wip

* wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants