Skip to content

Commit 4bf2555

Browse files
committed
Improve unpushed branch indicator style
- Use darker color in light mode to provide enough contrast - Change color to white when selected, to match other UI elements - Also make name bold so we're not relying on just color
1 parent a67a1a4 commit 4bf2555

4 files changed

Lines changed: 9 additions & 1 deletion

File tree

app/styles/_variables.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -547,6 +547,8 @@ $overlay-background-color: rgba(0, 0, 0, 0.4);
547547
--pr-commented-icon-color: var(--md-fg-muted-color);
548548
--pr-commented-icon-background-color: #eaeef2;
549549

550+
--unpushed-branch-color: #{$yellow-900};
551+
550552
--call-to-action-bubble-border-color: #{$green};
551553
--call-to-action-bubble-color: #{$green};
552554

app/styles/themes/_dark.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,8 @@ body.theme-dark {
430430
--pr-commented-icon-color: #8b949e;
431431
--pr-commented-icon-background-color: #{$gray-700};
432432

433+
--unpushed-branch-color: #{$yellow-600};
434+
433435
--call-to-action-bubble-background-color: #{$blue};
434436
--call-to-action-bubble-color: #{$white};
435437

app/styles/ui/_branches.scss

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,10 @@
189189
}
190190

191191
&.local-only {
192-
color: var(--dialog-warning-color);
192+
color: var(--unpushed-branch-color);
193+
.name {
194+
font-weight: var(--font-weight-semibold);
195+
}
193196
}
194197

195198
&.disabled {

app/styles/ui/_list.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
&.focus-within .list-item.selected:not(.in-keyboard-insertion-mode) {
8080
--text-color: var(--box-selected-active-text-color);
8181
--text-secondary-color: var(--box-selected-active-text-color);
82+
--unpushed-branch-color: var(--box-selected-active-text-color);
8283

8384
color: var(--text-color);
8485
background-color: var(--box-selected-active-background-color);

0 commit comments

Comments
 (0)