Skip to content

Commit 89c0e26

Browse files
committed
Make hideWindowOnQuit = true by default on macOS
Right now, this change doesn't do anything, because hideWindowOnQuit is ignored on macOS (see shouldHideWindowInsteadOfClose in app-window.ts). In the future, if we wanted macOS users to be able to fully close the main window, we would need to remove the __DARWIN__ check from shouldHideWindowInsteadOfClose, and then it would make sense for the default value to be true. Making this change now so that new installs start populating this setting with the correct value, reducing confusion in the long run.
1 parent 6ee9c94 commit 89c0e26

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

app/src/lib/stores/app-store.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ export class AppStore extends TypedBaseStore<IAppState> {
634634
private titleBarStyle: TitleBarStyle = 'native'
635635
private showRecentRepositories: boolean = true
636636
private showWorktrees: boolean = false
637-
private hideWindowOnQuit: boolean = false
637+
private hideWindowOnQuit: boolean = __DARWIN__
638638

639639
private useWindowsOpenSSH: boolean = false
640640

0 commit comments

Comments
 (0)