fix(sidebar): ignore stash metrics for synthetic worktree rows

Author: ignatremizov

app/src/lib/stores/repositories-store.ts

@@ -479,6 +479,12 @@ export class RepositoriesStore extends TypedBaseStore<
     repository: Repository,
     date: number = Date.now()
   ): Promise<void> {
+    // Synthetic sidebar-only worktree rows are transient repositories that
+    // are not persisted in the repositories store.
+    if (repository.id < 0) {
+      return
+    }
+
     await this.db.repositories.update(repository.id, {
       lastStashCheckDate: date,
     })
@@ -496,6 +502,12 @@ export class RepositoriesStore extends TypedBaseStore<
   public async getLastStashCheckDate(
     repository: Repository
   ): Promise<number | null> {
+    // Synthetic sidebar-only worktree rows are transient repositories that
+    // are not persisted in the repositories store.
+    if (repository.id < 0) {
+      return null
+    }
+
     let lastCheckDate = this.lastStashCheckCache.get(repository.id) || null
     if (lastCheckDate !== null) {
       return lastCheckDate

app/test/unit/repositories-store-test.ts

@@ -3,7 +3,11 @@ import assert from 'node:assert'
 import { RepositoriesStore } from '../../src/lib/stores/repositories-store'
 import { TestRepositoriesDatabase } from '../helpers/databases'
 import { IAPIFullRepository, getDotComAPIEndpoint } from '../../src/lib/api'
-import { assertIsRepositoryWithGitHubRepository } from '../../src/models/repository'
+import {
+  assertIsRepositoryWithGitHubRepository,
+  Repository,
+} from '../../src/models/repository'
+import { gitHubRepoFixture } from '../helpers/github-repo-builder'
 
 describe('RepositoriesStore', () => {
   let repoDb = new TestRepositoriesDatabase()
@@ -97,4 +101,22 @@ describe('RepositoriesStore', () => {
       )
     })
   })
+
+  describe('stash check tracking', () => {
+    it('ignores transient synthetic repositories', async () => {
+      const syntheticRepo = new Repository(
+        '/tmp/repo-feature-a',
+        -1,
+        gitHubRepoFixture({ owner: 'example', name: 'repo' }),
+        false
+      )
+
+      assert.equal(
+        await repositoriesStore.getLastStashCheckDate(syntheticRepo),
+        null
+      )
+
+      await repositoriesStore.updateLastStashCheckDate(syntheticRepo)
+    })
+  })
 })