Improve wording of "Set as default branch"

Author: pol-rivero

app/src/ui/branches/branch-list-item-context-menu.tsx

@@ -12,7 +12,7 @@ interface IBranchContextMenuConfig {
   onRenameBranch?: (branchName: string) => void
   onViewBranchOnGitHub?: () => void
   onViewPullRequestOnGitHub?: () => void
-  onMakeDefaultBranch?: (branchName: string) => void
+  onSetAsDefaultBranch?: (branchName: string) => void
   onDeleteBranch?: (branchName: string) => void
 }
 
@@ -28,7 +28,7 @@ export function generateBranchContextMenuItems(
     onRenameBranch,
     onViewBranchOnGitHub,
     onViewPullRequestOnGitHub,
-    onMakeDefaultBranch,
+    onSetAsDefaultBranch,
     onDeleteBranch,
   } = config
   const items = new Array<IMenuItem>()
@@ -60,10 +60,10 @@ export function generateBranchContextMenuItems(
     })
   }
 
-  if (onMakeDefaultBranch !== undefined) {
+  if (onSetAsDefaultBranch !== undefined) {
     items.push({
-      label: __DARWIN__ ? 'Make The Default Branch' : 'Make the default branch',
-      action: () => onMakeDefaultBranch(nameWithoutRemote),
+      label: __DARWIN__ ? 'Set as Default Branch' : 'Set as default branch',
+      action: () => onSetAsDefaultBranch(nameWithoutRemote),
     })
   }
 

app/src/ui/branches/branch-list.tsx

@@ -138,8 +138,8 @@ interface IBranchListProps {
   /** Optional: Callback for if rename context menu should exist */
   readonly onRenameBranch?: (branchName: string) => void
 
-  /** Optional: Callback for if make default branch context menu should exist */
-  readonly onMakeDefaultBranch?: (branchName: string) => void
+  /** Optional: Callback for if set as default branch context menu should exist */
+  readonly onSetAsDefaultBranch?: (branchName: string) => void
 
   /** Optional: Callback for if delete context menu should exist */
   readonly onDeleteBranch?: (branchName: string) => void
@@ -296,12 +296,12 @@ export class BranchList extends React.Component<
   ) => {
     event.preventDefault()
 
-    const { onRenameBranch, onDeleteBranch, onMakeDefaultBranch } = this.props
+    const { onRenameBranch, onDeleteBranch, onSetAsDefaultBranch } = this.props
 
     if (
       onRenameBranch === undefined &&
       onDeleteBranch === undefined &&
-      onMakeDefaultBranch === undefined
+      onSetAsDefaultBranch === undefined
     ) {
       return
     }
@@ -317,10 +317,10 @@ export class BranchList extends React.Component<
       repoType: this.props.repository.gitHubRepository?.type,
       isInUseByOtherWorktree,
       onRenameBranch,
-      onMakeDefaultBranch:
+      onSetAsDefaultBranch:
         nameWithoutRemote === this.props.defaultBranch?.name
           ? undefined
-          : onMakeDefaultBranch,
+          : onSetAsDefaultBranch,
       onDeleteBranch,
     })
 

app/src/ui/branches/branches-container.tsx

@@ -50,7 +50,7 @@ interface IBranchesContainerProps {
   readonly recentBranches: ReadonlyArray<Branch>
   readonly pullRequests: ReadonlyArray<PullRequest>
   readonly onRenameBranch: (branchName: string) => void
-  readonly onMakeDefaultBranch: (branchName: string) => void
+  readonly onSetAsDefaultBranch: (branchName: string) => void
   readonly onDeleteBranch: (branchName: string) => void
 
   /** All worktrees in the repository. */
@@ -295,7 +295,7 @@ export class BranchesContainer extends React.Component<
             )}
             renderPreList={this.renderPreList}
             onRenameBranch={this.props.onRenameBranch}
-            onMakeDefaultBranch={this.props.onMakeDefaultBranch}
+            onSetAsDefaultBranch={this.props.onSetAsDefaultBranch}
             onDeleteBranch={this.props.onDeleteBranch}
           />
         )

app/src/ui/toolbar/branch-dropdown.tsx

@@ -115,7 +115,7 @@ export class BranchDropdown extends React.Component<IBranchDropdownProps> {
         emoji={this.props.emoji}
         onDeleteBranch={this.onDeleteBranch}
         onRenameBranch={this.onRenameBranch}
-        onMakeDefaultBranch={this.onMakeDefaultBranch}
+        onSetAsDefaultBranch={this.onSetAsDefaultBranch}
         underlineLinks={this.props.underlineLinks}
       />
     )
@@ -327,10 +327,10 @@ export class BranchDropdown extends React.Component<IBranchDropdownProps> {
       onViewPullRequestOnGitHub: this.props.currentPullRequest
         ? this.onViewPullRequestOnGithub
         : undefined,
-      onMakeDefaultBranch:
+      onSetAsDefaultBranch:
         nameWithoutRemote === this.props.repository.defaultBranch
           ? undefined
-          : this.onMakeDefaultBranch,
+          : this.onSetAsDefaultBranch,
       onDeleteBranch: this.onDeleteBranch,
     })
 
@@ -390,7 +390,7 @@ export class BranchDropdown extends React.Component<IBranchDropdownProps> {
     this.props.dispatcher.showPullRequestByPR(pr)
   }
 
-  private onMakeDefaultBranch = (branchName: string) => {
+  private onSetAsDefaultBranch = (branchName: string) => {
     this.props.dispatcher.updateRepositoryDefaultBranch(
       this.props.repository,
       branchName