Skip to content

Commit c117357

Browse files
committed
Use the correct bundle identifier in macOS
Fixes #157
1 parent a33c7fe commit c117357

4 files changed

Lines changed: 11 additions & 27 deletions

File tree

.github/github-desktop-plus-release-notes.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,5 @@ Upstream: [GitHub Desktop 3.5.9-beta2 release notes](https://github.com/desktop/
1919
- Fixed an issue where the "Pull all" button in the repository list would ignore some repositories.
2020

2121
- [#154] Opening files in Cursor (text editor) should now work correctly.
22+
23+
- [#157] **macOS:** The app now uses the correct bundle identifier, instead of duplicating the one from GitHub Desktop.

app/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
"name": "github-desktop-plus",
44
"desktopName": "github-desktop-plus",
55
"productName": "GitHub Desktop Plus",
6-
"bundleID": "com.github.GitHubClient",
7-
"companyName": "GitHub, Inc.",
6+
"bundleID": "com.polrivero.GitHubDesktopPlus",
7+
"companyName": "Pol Rivero",
88
"version": "3.5.9-beta2",
99
"main": "./main.js",
1010
"repository": {
@@ -13,8 +13,8 @@
1313
},
1414
"description": "Simple collaboration from your desktop",
1515
"author": {
16-
"name": "GitHub, Inc.",
17-
"email": "opensource+desktop@github.com",
16+
"name": "Pol Rivero",
17+
"email": "github-desktop-plus@polrivero.com",
1818
"url": "https://desktop.github.com/"
1919
},
2020
"license": "MIT",

app/src/ui/about/about.tsx

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -194,25 +194,7 @@ export class About extends React.Component<IAboutProps> {
194194
}
195195

196196
private renderBetaLink() {
197-
if (__RELEASE_CHANNEL__ === 'beta') {
198-
return
199-
}
200-
201-
if (__LINUX__) {
202-
return
203-
}
204-
205-
return (
206-
<div>
207-
<p className="no-padding">Looking for the latest features?</p>
208-
<p className="no-padding">
209-
Check out the{' '}
210-
<LinkButton uri="https://desktop.github.com/beta">
211-
Beta Channel
212-
</LinkButton>
213-
</p>
214-
</div>
215-
)
197+
return
216198
}
217199

218200
public render() {

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
{
22
"repository": {
33
"type": "git",
4-
"url": "https://github.com/desktop/desktop.git"
4+
"url": "https://github.com/pol-rivero/github-desktop-plus.git"
55
},
6-
"description": "GitHub Desktop build dependencies",
6+
"description": "GitHub Desktop Plus build dependencies",
77
"scripts": {
88
"cli": "ts-node app/src/cli/main.ts",
99
"check:eslint": "tsc -P eslint-rules/",
@@ -51,8 +51,8 @@
5151
"validate-changelog": "ts-node -P script/tsconfig.json script/validate-changelog.ts"
5252
},
5353
"author": {
54-
"name": "GitHub, Inc.",
55-
"email": "opensource+desktop@github.com",
54+
"name": "Pol Rivero",
55+
"email": "github-desktop-plus@polrivero.com",
5656
"url": "https://desktop.github.com/"
5757
},
5858
"license": "MIT",

0 commit comments

Comments
 (0)