fix(sidebar): keep linked worktree rows as leaf nodes

Linked worktrees should never become alternate parents for a worktree family in the sidebar. After the earlier synthetic-row support, orphan linked worktrees could still synthesize sibling children underneath themselves, which made grouping unstable and produced confusing results when a saved linked worktree also had custom alias or group metadata.

Changes:
- stop synthesizing sibling worktree rows underneath orphan linked worktree entries so only main worktrees can own nested children
- use the linked worktree alias when present, otherwise fall back to the worktree basename, so saved linked rows can keep their explicit label without becoming a second group root
- treat both saved and synthetic linked worktree rows as `Delete…` targets in the sidebar context menu while keeping alias and group actions available only for saved rows
- extend the delete-worktree popup payload so deleting a saved linked worktree also removes its stored Desktop repository entry, and so deleting the currently selected synthetic worktree still switches away safely before removal
- add regression coverage for orphan linked rows staying flat and for the saved-vs-virtual linked worktree context menu behavior

Behavioral effect:
Known linked worktrees now remain leaf rows unless they are displayed under their actual main worktree. Saved linked worktrees no longer sprout sibling children under custom groups, and deleting either a saved or synthetic linked worktree uses the same linked-worktree action while keeping Desktop's repository store in sync.

Testing:
- yarn test:unit app/test/unit/repositories-list-grouping-test.ts
- yarn test:unit app/test/unit/repository-list-item-context-menu-test.ts
- yarn eslint app/src/ui/repositories-list/worktree-list-items.ts app/src/ui/repositories-list/repository-list-item-context-menu.ts app/src/ui/repositories-list/repositories-list.tsx app/src/ui/worktrees/delete-worktree-dialog.tsx app/src/ui/app.tsx app/src/models/popup.ts app/test/unit/repositories-list-grouping-test.ts app/test/unit/repository-list-item-context-menu-test.ts
- yarn compile:prod

Author: ignatremizov

app/src/models/popup.ts

@@ -513,5 +513,7 @@ export type PopupDetail =
       type: PopupType.DeleteWorktree
       repository: Repository
       worktreePath: string
+      storedRepositoryToRemove?: Repository
+      isDeletingCurrentWorktree?: boolean
     }
 export type Popup = IBasePopup & PopupDetail

app/src/ui/app.tsx

@@ -2763,6 +2763,8 @@ export class App extends React.Component<IAppProps, IAppState> {
             key="delete-worktree"
             repository={popup.repository}
             worktreePath={popup.worktreePath}
+            storedRepositoryToRemove={popup.storedRepositoryToRemove}
+            isDeletingCurrentWorktree={popup.isDeletingCurrentWorktree}
             dispatcher={this.props.dispatcher}
             onDismissed={onPopupDismissedFn}
           />

app/src/ui/repositories-list/repositories-list.tsx

@@ -449,6 +449,10 @@ export class RepositoriesList extends React.Component<
         : item.repository instanceof Repository
         ? item.repository
         : null
+    const storedRepositoryToRemove =
+      item.repository instanceof Repository && !item.isVirtualLinkedWorktree
+        ? item.repository
+        : undefined
 
     if (repository === null) {
       return
@@ -458,6 +462,11 @@ export class RepositoriesList extends React.Component<
       type: PopupType.DeleteWorktree,
       repository,
       worktreePath,
+      storedRepositoryToRemove,
+      isDeletingCurrentWorktree:
+        this.props.selectedRepository !== null &&
+        normalizePath(this.props.selectedRepository.path) ===
+          normalizePath(worktreePath),
     })
   }
 
@@ -490,7 +499,11 @@ export class RepositoriesList extends React.Component<
       onOpenInExternalEditor: this.props.onOpenInExternalEditor,
       askForConfirmationOnRemoveRepository:
         this.props.askForConfirmationOnRemoveRepository,
-      isLinkedWorktreeRow: item.isVirtualLinkedWorktree,
+      isLinkedWorktreeRow:
+        item.isVirtualLinkedWorktree ||
+        (item.repository instanceof Repository &&
+          item.repository.isLinkedWorktree),
+      isVirtualLinkedWorktreeRow: item.isVirtualLinkedWorktree,
       isPrunableWorktreeRow: item.isPrunableWorktree,
       externalEditorLabel: this.props.externalEditorLabel,
       onChangeRepositoryAlias: this.onChangeRepositoryAlias,

app/src/ui/repositories-list/repository-list-item-context-menu.ts

@@ -19,6 +19,7 @@ interface IRepositoryListItemContextMenuConfig {
   externalEditorLabel: string | undefined
   askForConfirmationOnRemoveRepository: boolean
   readonly isLinkedWorktreeRow?: boolean
+  readonly isVirtualLinkedWorktreeRow?: boolean
   readonly isPrunableWorktreeRow?: boolean
   onViewInBrowser: (repository: Repositoryish) => void
   onOpenInNewWindow?: (repository: Repositoryish) => void
@@ -159,7 +160,10 @@ const buildAliasMenuItems = (
 ): ReadonlyArray<IMenuItem> => {
   const { repository } = config
 
-  if (!(repository instanceof Repository) || config.isLinkedWorktreeRow) {
+  if (
+    !(repository instanceof Repository) ||
+    config.isVirtualLinkedWorktreeRow
+  ) {
     return []
   }
 
@@ -186,7 +190,10 @@ const buildGroupNameMenuItems = (
 ): ReadonlyArray<IMenuItem> => {
   const { repository } = config
 
-  if (!(repository instanceof Repository) || config.isLinkedWorktreeRow) {
+  if (
+    !(repository instanceof Repository) ||
+    config.isVirtualLinkedWorktreeRow
+  ) {
     return []
   }
 

app/src/ui/repositories-list/worktree-list-items.ts

@@ -23,14 +23,22 @@ export const getDisplayTitle = (repository: Repositoryish) =>
     ? repository.alias
     : repository.name
 
+const getLinkedWorktreeDisplayTitle = (
+  repository: Repositoryish,
+  worktreePath?: string
+) =>
+  repository instanceof Repository && repository.alias != null
+    ? repository.alias
+    : Path.basename(worktreePath ?? repository.path)
+
 export const getRepositoryListTitle = (
   repository: Repositoryish,
   showWorktreesInSidebar: boolean
 ) =>
   showWorktreesInSidebar &&
   repository instanceof Repository &&
   repository.isLinkedWorktree
-    ? Path.basename(repository.path)
+    ? getLinkedWorktreeDisplayTitle(repository)
     : getDisplayTitle(repository)
 
 const getVirtualRepositoryId = (worktreePath: string) => {
@@ -138,7 +146,7 @@ export function toSortedRepositoryListItems({
         : null
     const title =
       isLinkedWorktree || isVirtualLinkedWorktree
-        ? Path.basename(worktreePath)
+        ? getLinkedWorktreeDisplayTitle(repository, worktreePath)
         : getDisplayTitle(repository)
     const defaultBranchName =
       repoState?.defaultBranchName ??
@@ -313,12 +321,6 @@ export function toSortedRepositoryListItems({
 
   for (const repository of orphanLinkedRepos) {
     items.push(toListItem(repository, false))
-    appendVirtualWorktreeItems(
-      items,
-      repository,
-      repository,
-      emittedVirtualPaths
-    )
   }
 
   return items

app/src/ui/worktrees/delete-worktree-dialog.tsx

@@ -16,6 +16,8 @@ import {
 interface IDeleteWorktreeDialogProps {
   readonly repository: Repository
   readonly worktreePath: string
+  readonly storedRepositoryToRemove?: Repository
+  readonly isDeletingCurrentWorktree?: boolean
   readonly dispatcher: Dispatcher
   readonly onDismissed: () => void
 }
@@ -66,9 +68,13 @@ export class DeleteWorktreeDialog extends React.Component<
   private onDeleteWorktree = async () => {
     this.setState({ isDeleting: true })
 
-    const { repository, worktreePath, dispatcher } = this.props
-    const isDeletingCurrentWorktree =
-      normalizePath(repository.path) === normalizePath(worktreePath)
+    const {
+      repository,
+      worktreePath,
+      dispatcher,
+      storedRepositoryToRemove,
+      isDeletingCurrentWorktree = false,
+    } = this.props
 
     const mainPathForCleanup = await getMainWorktreePath(repository)
 
@@ -94,9 +100,13 @@ export class DeleteWorktreeDialog extends React.Component<
         const mainRepo = addedRepos[0]
         await dispatcher.selectRepository(mainRepo)
         await removeWorktree(mainRepo, worktreePath)
-        await dispatcher.removeRepository(repository, false)
       } else {
         await removeWorktree(repository, worktreePath)
+      }
+
+      if (storedRepositoryToRemove !== undefined) {
+        await dispatcher.removeRepository(storedRepositoryToRemove, false)
+      } else if (!isDeletingCurrentWorktree) {
         await dispatcher.refreshRepository(repository)
       }
     } catch (e) {

app/test/unit/repositories-list-grouping-test.ts

@@ -390,4 +390,92 @@ describe('repository list grouping', () => {
       await rm(tempRoot, { recursive: true, force: true })
     }
   })
+
+  it('does not synthesize linked worktree siblings under orphan linked worktrees', async () => {
+    const tempRoot = await mkdtemp(
+      path.join(os.tmpdir(), 'github-desktop-plus-worktree-orphan-leaf-')
+    )
+    try {
+      const mainRepoPath = path.join(tempRoot, 'repo')
+      const linkedRepoPath = path.join(tempRoot, 'repo-feature-a')
+      const secondLinkedRepoPath = path.join(tempRoot, 'repo-feature-b')
+
+      await mkdir(path.join(mainRepoPath, '.git'), { recursive: true })
+      await mkdir(path.join(mainRepoPath, '.git', 'worktrees', 'feature-a'), {
+        recursive: true,
+      })
+      await mkdir(path.join(mainRepoPath, '.git', 'worktrees', 'feature-b'), {
+        recursive: true,
+      })
+      await mkdir(linkedRepoPath, { recursive: true })
+      await writeFile(
+        path.join(linkedRepoPath, '.git'),
+        'gitdir: ../repo/.git/worktrees/feature-a\n'
+      )
+      await writeFile(
+        path.join(mainRepoPath, '.git', 'worktrees', 'feature-a', 'commondir'),
+        '../..\n'
+      )
+      await writeFile(
+        path.join(mainRepoPath, '.git', 'worktrees', 'feature-b', 'commondir'),
+        '../..\n'
+      )
+
+      const linkedRepo = new Repository(
+        linkedRepoPath,
+        20,
+        gitHubRepoFixture({ owner: 'example', name: 'repo' }),
+        false,
+        'custom alias'
+      )
+
+      cache.set(linkedRepo.id, {
+        aheadBehind: null,
+        changedFilesCount: 0,
+        branchName: 'feature/a',
+        defaultBranchName: 'main',
+        allWorktrees: [
+          {
+            path: mainRepoPath,
+            head: 'a',
+            branch: 'refs/heads/main',
+            isDetached: false,
+            type: 'main',
+            isLocked: false,
+            isPrunable: false,
+          },
+          {
+            path: linkedRepoPath,
+            head: 'b',
+            branch: 'refs/heads/feature/a',
+            isDetached: false,
+            type: 'linked',
+            isLocked: false,
+            isPrunable: false,
+          },
+          {
+            path: secondLinkedRepoPath,
+            head: 'c',
+            branch: 'refs/heads/feature/b',
+            isDetached: false,
+            type: 'linked',
+            isLocked: false,
+            isPrunable: false,
+          },
+        ],
+      })
+
+      const grouped = groupRepositories([linkedRepo], cache, [], {
+        showWorktreesInSidebar: true,
+      })
+
+      assert.equal(grouped.length, 1)
+      assert.equal(grouped[0].items.length, 1)
+      assert.equal(grouped[0].items[0].repository.path, linkedRepoPath)
+      assert.equal(grouped[0].items[0].isNestedWorktree, false)
+      assert.equal(grouped[0].items[0].title, 'custom alias')
+    } finally {
+      await rm(tempRoot, { recursive: true, force: true })
+    }
+  })
 })

app/test/unit/repository-list-item-context-menu-test.ts

@@ -66,6 +66,7 @@ describe('repository list item context menu', () => {
     const items = generateRepositoryListContextMenu(
       buildConfig({
         isLinkedWorktreeRow: true,
+        isVirtualLinkedWorktreeRow: true,
         onRemoveRepository: () => {
           removedRepository = true
         },
@@ -98,6 +99,30 @@ describe('repository list item context menu', () => {
     assert.equal(removedRepository, false)
   })
 
+  it('keeps alias and group name actions for saved linked worktree rows', () => {
+    const items = generateRepositoryListContextMenu(
+      buildConfig({
+        isLinkedWorktreeRow: true,
+        isVirtualLinkedWorktreeRow: false,
+        onRemoveLinkedWorktree: () => {},
+      })
+    )
+    const labels = items.flatMap(item => ('label' in item ? [item.label] : []))
+
+    assert(labels.includes('Change alias') || labels.includes('Change Alias'))
+    assert(labels.includes('Remove alias') || labels.includes('Remove Alias'))
+    assert(
+      labels.includes('Change group name') ||
+        labels.includes('Change Group Name')
+    )
+    assert(
+      labels.includes('Restore group name') ||
+        labels.includes('Restore Group Name')
+    )
+    assert(labels.includes('Delete…'))
+    assert(!labels.includes('Remove…'))
+  })
+
   it('shows a prune action for stale worktree rows and keeps remove semantics', () => {
     let prunedStaleWorktrees = false
     let removedRepository = false
@@ -140,6 +165,7 @@ describe('repository list item context menu', () => {
     const items = generateRepositoryListContextMenu(
       buildConfig({
         isLinkedWorktreeRow: true,
+        isVirtualLinkedWorktreeRow: true,
         isPrunableWorktreeRow: true,
         onPruneStaleWorktrees: () => {},
       })