Skip to content

Fix electron-installer-redhat RPM spec copy path #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pol-rivero merged 1 commit into from
Feb 1, 2026
Merged

Fix electron-installer-redhat RPM spec copy path #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions patches/electron-installer-redhat+3.4.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,8 @@ index e07a8a3..486f59e 100644

%if "%{_host_cpu}" != "%{_target_cpu}"
%global __strip /bin/true
@@ -26,3 +27,3 @@
%>%install
Copy link

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff prefix on this line is incorrect. It should be a space character ( %install), not a greater-than sign (>%install). In unified diff format, unchanged context lines must start with a space, while added lines start with + and removed lines start with -. The > character is not a valid diff prefix and will cause patch-package to fail when applying this patch.

Suggested change
%>%install
%install

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner

@pol-rivero pol-rivero Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

False positive

mkdir -p %{buildroot}/usr/
-cp <%= process.platform === 'darwin' ? '-R' : '-r' %> usr/* %{buildroot}/usr/
+cp <%= process.platform === 'darwin' ? '-R' : '-r' %> %{_topdir}/BUILD/usr/* %{buildroot}/usr/