Improved the Room ID Generation Algorithm

polius · polius · commit 0516d0c580a9 · 2024-05-27T19:48:59.000+02:00
diff --git a/src/js/script.js b/src/js/script.js
@@ -303,7 +303,7 @@ function generateRoomID() {
   const random = crypto.getRandomValues(new Uint8Array(length));
   let room_id = "";
   for (let i = 0; i < length; i++) {
-    room_id += alphabet[alphabet.length & random[i]];
+    room_id += alphabet[random[i] % alphabet.length];
   }
   return `${room_id.slice(0, 3)}-${room_id.slice(3, 7)}-${room_id.slice(7, 10)}`;
 }

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ function generateRoomID() {`
`303`	`303`	`const random = crypto.getRandomValues(new Uint8Array(length));`
`304`	`304`	`let room_id = "";`
`305`	`305`	`for (let i = 0; i < length; i++) {`
`306`		`- room_id += alphabet[alphabet.length & random[i]];`
	`306`	`+ room_id += alphabet[random[i] % alphabet.length];`
`307`	`307`	`}`
`308`	`308`	return `${room_id.slice(0, 3)}-${room_id.slice(3, 7)}-${room_id.slice(7, 10)}`;
`309`	`309`	`}`