Changed CodeSniffer error levels

- No error exit code for warnings
- Changed entire ruleset to ERROR level
- Left PhpDoc\RequiredForPublicApiSniff on WARNING level
- Added colors to output in composer.json & build.yml

Author: shudd3r

.github/workflows/build.yml

@@ -45,8 +45,8 @@ jobs:
         run: vendor/bin/php-cs-fixer --dry-run -v --config=cs-fixer.php.dist --path-mode=intersection fix src tests
       - name: "Coding standard CodeSniffer checks"
         run: |
-          vendor/bin/phpcs --extensions=php --standard=phpcs.xml.dist src
-          vendor/bin/phpcs --extensions=php --standard=phpcs.xml.dist --ignore=*/code-samples/* tests
+          vendor/bin/phpcs --extensions=php --standard=phpcs.xml.dist --colors src
+          vendor/bin/phpcs --extensions=php --standard=phpcs.xml.dist --colors --ignore=*/code-samples/* tests
       - name: "Package skeleton validation"
         run: php polymorphine-skeleton check
       - name: "Run PhpUnit tests with coverage"

composer.json

@@ -34,8 +34,8 @@
     "scripts": {
         "test-cs": [
             "php-cs-fixer --dry-run -v --config=cs-fixer.php.dist --path-mode=intersection fix src tests",
-            "phpcs --extensions=php --standard=phpcs.xml.dist src",
-            "phpcs --extensions=php --standard=phpcs.xml.dist --ignore=*/code-samples/* tests"
+            "phpcs --extensions=php --standard=phpcs.xml.dist --colors src",
+            "phpcs --extensions=php --standard=phpcs.xml.dist --colors --ignore=*/code-samples/* tests"
         ],
         "test-php": "phpunit",
         "test-skeleton": "@php polymorphine-skeleton check"

phpcs.xml

@@ -1,9 +1,13 @@
 <?xml version="1.0"?>
 <!-- Code Sniffer configuration for projects using Polymorphine\Dev coding standard as composer dependency -->
 <ruleset name="polymorphine-package">
+    <config name="ignore_warnings_on_exit" value="true"/>
     <autoload>../../autoload.php</autoload>
-    <rule ref="./src/Sniffer"/>
+    <rule ref="./src/Sniffer">
+        <type>error</type>
+    </rule>
     <rule ref="Sniffer.PhpDoc.RequiredForPublicApi">
+        <type>warning</type>
         <exclude-pattern>*/tests/*</exclude-pattern>
     </rule>
 </ruleset>

phpcs.xml.dist

@@ -1,9 +1,13 @@
 <?xml version="1.0"?>
-<!-- Code Sniffer configuration for Polymorphine/Dev package files -->
+<!-- Code Sniffer configuration for Polymorphine/Dev package itself -->
 <ruleset name="polymorphine-dev">
+    <config name="ignore_warnings_on_exit" value="true"/>
     <autoload>./vendor/autoload.php</autoload>
-    <rule ref="./src/Sniffer"/>
+    <rule ref="./src/Sniffer">
+        <type>error</type>
+    </rule>
     <rule ref="Sniffer.PhpDoc.RequiredForPublicApi">
+        <type>warning</type>
         <exclude-pattern>*/tests/*</exclude-pattern>
     </rule>
 </ruleset>

template/.github/workflows/build.yml

@@ -45,8 +45,8 @@ jobs:
         run: vendor/bin/php-cs-fixer --dry-run -v --config=cs-fixer.php.dist --path-mode=intersection fix src tests
       - name: "Coding standard CodeSniffer checks"
         run: |
-          vendor/bin/phpcs --extensions=php --standard=${tpl.PHPCS} src
-          vendor/bin/phpcs --extensions=php --standard=${tpl.PHPCS} --ignore=*/code-samples/* tests
+          vendor/bin/phpcs --extensions=php --standard=${tpl.PHPCS} --colors src
+          vendor/bin/phpcs --extensions=php --standard=${tpl.PHPCS} --colors --ignore=*/code-samples/* tests
       - name: "Package skeleton validation"
         run: ${tpl.PHP_EXEC}polymorphine-skeleton check
       - name: "Run PhpUnit tests with coverage"

template/composer.json.sk_file

@@ -31,8 +31,8 @@
     "scripts": {
         "test-cs": [
             "php-cs-fixer --dry-run -v --config=cs-fixer.php.dist --path-mode=intersection fix src tests",
-            "phpcs --extensions=php --standard={$tpl.PHPCS} src",
-            "phpcs --extensions=php --standard={$tpl.PHPCS} --ignore=*/code-samples/* tests"
+            "phpcs --extensions=php --standard={$tpl.PHPCS} --colors src",
+            "phpcs --extensions=php --standard={$tpl.PHPCS} --colors --ignore=*/code-samples/* tests"
         ],
         "test-php": "phpunit",
         "test-skeleton": "{$tpl.PHP_EXEC}polymorphine-skeleton check"