[sdk]: clear stale reverse mapping in setEidMapping#876
Merged
Conversation
Wizdave97
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HyperbridgeLzEndpoint.setEidMappingpreviously overwrote the forward map_eidToStateMachine[lzEid]and added a new reverse map entry, but never deleted the prior state machine's reverse entry. Inbound source authorization inonAcceptreads only_stateMachineToEid[keccak256(request.source)], so a remapped or "disabled" EID continued to authorize messages from the previously-trusted state machine (incomplete revocation).setEidMappingnow reads the prior state machine, deletes its reverse entry if non-empty, writes the new forward, and writes the new reverse only whenstateMachineIdis non-empty. Clean disable path with nokeccak256("")residue.Tests
Added fork-free unit tests at
sdk/packages/lz-endpoint/test/HyperbridgeLzEndpointConfigTest.solcovering:testRemapClearsPriorReverseEntry—setEidMapping(101, A)→setEidMapping(101, B)leaveseidFor(A) == 0andeidFor(B) == 101.testDisableClearsReverseAndAvoidsEmptyKeyResidue—setEidMapping(101, A)→setEidMapping(101, hex"")clearseidFor(A), does not populateeidFor(hex""), andisSupportedEid(101)is false.testSetEidMappingIsIdempotent— same args twice ends in byte-identical state.testReassignStateMachineAcrossEidsPointsReverseToLatest— admin remap of the same state machine across two EIDs leaves the reverse pointing to the latest EID; sanity check for behavior under admin mistake.All 4 tests pass locally:
Split into a separate file from
HyperbridgeLzEndpointTest.solbecause the new tests are pure config-state checks and don't need the mainnet fork (MAINNET_FORK_URL) that the existing E2E tests require.