[sdk]: reject srcEid=0 in HyperbridgeLzEndpoint to close unregistered-source collision#888
Merged
Merged
Conversation
…-source collision
Wizdave97
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onAcceptpreviously gated source authenticity withexpectedEid != srcEidonly. For any state machine not in_stateMachineToEid,expectedEiddefaults to0; an attacker who occupies the CREATE2 slot ofaddress(this)on that chain can dispatch withsrcEid = 0in the body and bypass the gate, delivering a forgedOrigininto any non-OApp receiver bound to the endpoint.expectedEid == 0reject inonAccept, and rejectslzEid == 0insetEidMappingto close the misconfiguration variant of the same collision. NewInvalidEid()error.HyperbridgeLzEndpointConfigTest:testRejectZeroEid,testOnAcceptRejectsSrcEidZeroFromUnregisteredSource,testOnAcceptRejectsSrcEidZeroFromDisabledSource. Each fails against the pre-fix contract (verified by temporarily reverting the guard).Test plan
forge test --match-contract HyperbridgeLzEndpointConfigTest— 7/7 passexpectedEid == 0guard removed, the two newonAccepttests fail (revert observed but notUnknownSource— exploit path slips past the gate and reacheslzReceive)send/quotepaths — existing OFT flows unaffected