refactor: polywrap-config-builder (#188)

Author: Niraj-Kamdar

.gitignore

@@ -104,9 +104,7 @@ celerybeat.pid
 # Environments
 .env
 .venv
-env/
 venv/
-ENV/
 env.bak/
 venv.bak/
 

packages/polywrap-client-config-builder/polywrap_client_config_builder/__init__.py

@@ -1,3 +1,4 @@
 """This package contains modules related to client config builder."""
 
 from .polywrap_client_config_builder import *
+from .types import *

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/base_configure.py

@@ -1,8 +1,10 @@
 """This module contains the base configure class for the client config builder."""
+from abc import ABC
+
 from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class BaseConfigure(ClientConfigBuilder):
+class BaseConfigure(ClientConfigBuilder, ABC):
     """BaseConfigure is the base configure class for the client config builder.
 
     Attributes:

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/env_configure.py

@@ -1,36 +1,39 @@
 """This module contains the env configure class for the client config builder."""
-from typing import Dict, List, Union
+from abc import ABC
+from typing import Any, Dict, List, Union
 
-from polywrap_core import Env, Uri
+from polywrap_core import Uri
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class EnvConfigure(ClientConfigBuilder):
+class EnvConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the environment variables."""
 
-    def get_env(self, uri: Uri) -> Union[Env, None]:
+    config: BuilderConfig
+
+    def get_env(self, uri: Uri) -> Union[Any, None]:
         """Return the env for the given uri."""
         return self.config.envs.get(uri)
 
-    def get_envs(self) -> Dict[Uri, Env]:
+    def get_envs(self) -> Dict[Uri, Any]:
         """Return the envs from the builder's config."""
         return self.config.envs
 
-    def set_env(self, uri: Uri, env: Env) -> ClientConfigBuilder:
+    def set_env(self, uri: Uri, env: Any) -> ClientConfigBuilder:
         """Set the env by uri in the builder's config, overiding any existing values."""
         self.config.envs[uri] = env
         return self
 
-    def set_envs(self, uri_envs: Dict[Uri, Env]) -> ClientConfigBuilder:
+    def set_envs(self, uri_envs: Dict[Uri, Any]) -> ClientConfigBuilder:
         """Set the envs in the builder's config, overiding any existing values."""
         self.config.envs.update(uri_envs)
         return self
 
-    def add_env(self, uri: Uri, env: Env) -> ClientConfigBuilder:
+    def add_env(self, uri: Uri, env: Any) -> ClientConfigBuilder:
         """Add an env for the given uri.
 
-        If an Env is already associated with the uri, it is modified.
+        If an Any is already associated with the uri, it is modified.
         """
         if self.config.envs.get(uri):
             for key in self.config.envs[uri]:
@@ -39,7 +42,7 @@ def add_env(self, uri: Uri, env: Env) -> ClientConfigBuilder:
             self.config.envs[uri] = env
         return self
 
-    def add_envs(self, uri_envs: Dict[Uri, Env]) -> ClientConfigBuilder:
+    def add_envs(self, uri_envs: Dict[Uri, Any]) -> ClientConfigBuilder:
         """Add a list of envs to the builder's config."""
         for uri, env in uri_envs.items():
             self.add_env(uri, env)

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/interface_configure.py

@@ -1,14 +1,17 @@
 """This module contains the interface configure class for the client config builder."""
+from abc import ABC
 from typing import Dict, List, Union
 
 from polywrap_core import Uri
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class InterfaceConfigure(ClientConfigBuilder):
+class InterfaceConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the interface-implementations."""
 
+    config: BuilderConfig
+
     def get_interfaces(self) -> Dict[Uri, List[Uri]]:
         """Return all registered interface and its implementations\
             from the builder's config."""

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/package_configure.py

@@ -1,32 +1,31 @@
 """This module contains the package configure class for the client config builder."""
+from abc import ABC
 from typing import Dict, List, Union
 
-from polywrap_core import Uri, UriPackageOrWrapper, WrapPackage
+from polywrap_core import Uri, WrapPackage
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class PackageConfigure(ClientConfigBuilder):
+class PackageConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the WRAP packages."""
 
-    def get_package(self, uri: Uri) -> Union[WrapPackage[UriPackageOrWrapper], None]:
+    config: BuilderConfig
+
+    def get_package(self, uri: Uri) -> Union[WrapPackage, None]:
         """Return the package for the given uri."""
         return self.config.packages.get(uri)
 
-    def get_packages(self) -> Dict[Uri, WrapPackage[UriPackageOrWrapper]]:
+    def get_packages(self) -> Dict[Uri, WrapPackage]:
         """Return the packages from the builder's config."""
         return self.config.packages
 
-    def set_package(
-        self, uri: Uri, package: WrapPackage[UriPackageOrWrapper]
-    ) -> ClientConfigBuilder:
+    def set_package(self, uri: Uri, package: WrapPackage) -> ClientConfigBuilder:
         """Set the package by uri in the builder's config, overiding any existing values."""
         self.config.packages[uri] = package
         return self
 
-    def set_packages(
-        self, uri_packages: Dict[Uri, WrapPackage[UriPackageOrWrapper]]
-    ) -> ClientConfigBuilder:
+    def set_packages(self, uri_packages: Dict[Uri, WrapPackage]) -> ClientConfigBuilder:
         """Set the packages in the builder's config, overiding any existing values."""
         self.config.packages.update(uri_packages)
         return self

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/redirect_configure.py

@@ -1,14 +1,17 @@
 """This module contains the redirect configure class for the client config builder."""
+from abc import ABC
 from typing import Dict, List, Union
 
 from polywrap_core import Uri
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class RedirectConfigure(ClientConfigBuilder):
+class RedirectConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the URI redirects."""
 
+    config: BuilderConfig
+
     def get_redirect(self, uri: Uri) -> Union[Uri, None]:
         """Return the redirect for the given uri."""
         return self.config.redirects.get(uri)

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/resolver_configure.py

@@ -1,14 +1,17 @@
 """This module contains the resolver configure class for the client config builder."""
+from abc import ABC
 from typing import List
 
 from polywrap_core import UriResolver
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class ResolverConfigure(ClientConfigBuilder):
+class ResolverConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the URI resolvers."""
 
+    config: BuilderConfig
+
     def get_resolvers(self) -> List[UriResolver]:
         """Return the resolvers from the builder's config."""
         return self.config.resolvers

packages/polywrap-client-config-builder/polywrap_client_config_builder/configures/wrapper_configure.py

@@ -1,32 +1,31 @@
 """This module contains the wrapper configure class for the client config builder."""
+from abc import ABC
 from typing import Dict, List, Union
 
-from polywrap_core import Uri, UriPackageOrWrapper, Wrapper
+from polywrap_core import Uri, Wrapper
 
-from ..types import ClientConfigBuilder
+from ..types import BuilderConfig, ClientConfigBuilder
 
 
-class WrapperConfigure(ClientConfigBuilder):
+class WrapperConfigure(ClientConfigBuilder, ABC):
     """Allows configuring the wrappers."""
 
-    def get_wrapper(self, uri: Uri) -> Union[Wrapper[UriPackageOrWrapper], None]:
+    config: BuilderConfig
+
+    def get_wrapper(self, uri: Uri) -> Union[Wrapper, None]:
         """Return the set wrapper for the given uri."""
         return self.config.wrappers.get(uri)
 
-    def get_wrappers(self) -> Dict[Uri, Wrapper[UriPackageOrWrapper]]:
+    def get_wrappers(self) -> Dict[Uri, Wrapper]:
         """Return the wrappers from the builder's config."""
         return self.config.wrappers
 
-    def set_wrapper(
-        self, uri: Uri, wrapper: Wrapper[UriPackageOrWrapper]
-    ) -> ClientConfigBuilder:
+    def set_wrapper(self, uri: Uri, wrapper: Wrapper) -> ClientConfigBuilder:
         """Set the wrapper by uri in the builder's config, overiding any existing values."""
         self.config.wrappers[uri] = wrapper
         return self
 
-    def set_wrappers(
-        self, uri_wrappers: Dict[Uri, Wrapper[UriPackageOrWrapper]]
-    ) -> ClientConfigBuilder:
+    def set_wrappers(self, uri_wrappers: Dict[Uri, Wrapper]) -> ClientConfigBuilder:
         """Set the wrappers in the builder's config, overiding any existing values."""
         self.config.wrappers.update(uri_wrappers)
         return self

packages/polywrap-client-config-builder/polywrap_client_config_builder/polywrap_client_config_builder.py

@@ -1,18 +1,17 @@
 """This module provides a simple builder for building a ClientConfig object."""
 # pylint: disable=too-many-ancestors
 
-from typing import Optional
+from typing import Optional, cast
 
-from polywrap_core import ClientConfig
+from polywrap_core import ClientConfig, UriPackage, UriWrapper
 from polywrap_uri_resolvers import (
     ExtendableUriResolver,
-    InMemoryWrapperCache,
-    PackageToWrapperResolver,
+    InMemoryResolutionResultCache,
     RecursiveResolver,
-    RequestSynchronizerResolver,
+    ResolutionResultCacheResolver,
     StaticResolver,
+    StaticResolverLike,
     UriResolverAggregator,
-    WrapperCacheResolver,
 )
 
 from .configures import (
@@ -51,30 +50,33 @@ def __init__(self):
         self.config = BuilderConfig(
             envs={}, interfaces={}, resolvers=[], wrappers={}, packages={}, redirects={}
         )
+        super().__init__()
 
     def build(self, options: Optional[BuildOptions] = None) -> ClientConfig:
         """Build the ClientConfig object from the builder's config."""
+        static_resolver_like = cast(StaticResolverLike, self.config.redirects)
+
+        for uri, wrapper in self.config.wrappers.items():
+            static_resolver_like[uri] = UriWrapper(uri=uri, wrapper=wrapper)
+
+        for uri, package in self.config.packages.items():
+            static_resolver_like[uri] = UriPackage(uri=uri, package=package)
+
         resolver = (
             options.resolver
             if options and options.resolver
             else RecursiveResolver(
-                RequestSynchronizerResolver(
-                    WrapperCacheResolver(
-                        PackageToWrapperResolver(
-                            UriResolverAggregator(
-                                [
-                                    StaticResolver(self.config.redirects),
-                                    StaticResolver(self.config.wrappers),
-                                    StaticResolver(self.config.packages),
-                                    *self.config.resolvers,
-                                    ExtendableUriResolver(),
-                                ]
-                            )
-                        ),
-                        options.wrapper_cache
-                        if options and options.wrapper_cache
-                        else InMemoryWrapperCache(),
-                    )
+                ResolutionResultCacheResolver(
+                    UriResolverAggregator(
+                        [
+                            StaticResolver(static_resolver_like),
+                            *self.config.resolvers,
+                            ExtendableUriResolver(),
+                        ]
+                    ),
+                    options.resolution_result_cache
+                    if options and options.resolution_result_cache
+                    else InMemoryResolutionResultCache(),
                 )
             )
         )
@@ -84,3 +86,6 @@ def build(self, options: Optional[BuildOptions] = None) -> ClientConfig:
             interfaces=self.config.interfaces,
             resolver=resolver,
         )
+
+
+__all__ = ["PolywrapClientConfigBuilder"]