Commit 4e0e5a3
Bundle commons-codec with common.eval to complete commons-csv's closure
The commons-io fix in v5.6.0 (#65) got the bundled commons-csv past its first
missing transitive dependency, but commons-csv 1.12.0's runtime closure is
both commons-io and commons-codec: it references
org.apache.commons.codec.binary.Base64OutputStream, yielding a second
NoClassDefFoundError under strict OSGi classloading in a materialized product.
commons-csv's own OSGi manifest enumerates its complete runtime closure via
Import-Package: exactly org.apache.commons.codec.binary and the
org.apache.commons.io.* packages. So the closure is bounded (io plus codec),
not open-ended. Bundle commons-codec 1.17.1 the same way commons-io and
commons-csv are bundled: self-contained, private to this bundle's classloader
(not exported), so common.eval carries its entire commons-csv closure inside
its own classloader regardless of what else the product assembles.
Maintenance note: on each future commons-csv upgrade, re-check the csv jar's
manifest Import-Package and bundle any newly added transitive dependency.
Re #64.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015jRmWZMAqpMDjsKmTATy3A1 parent 3523fc8 commit 4e0e5a3
6 files changed
Lines changed: 9 additions & 2 deletions
File tree
- edu.cuny.citytech.refactoring.common.eval
- META-INF
- lib
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
25 | 30 | | |
26 | 31 | | |
27 | 32 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
| 8 | + | |
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 commit comments