Exclude category.xml from spotless and match site.xml formatting#54
Merged
Conversation
The eclipseWtp XML formatter had collapsed the category description onto the <description> line with a leading space (flagged in review). Its sibling Eclipse descriptors (site.xml, feature.xml, plugin.xml) are already excluded from that formatter; add category.xml too, and format its description on its own line to match site.xml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa
There was a problem hiding this comment.
Pull request overview
Updates Spotless configuration to stop reformatting the hand-authored Eclipse update-site category.xml, and aligns category.xml’s <description> formatting with the existing site.xml style so it renders without unintended leading whitespace.
Changes:
- Exclude
**/category.xmlfrom Spotless’eclipseWtpXML formatter (alongsidesite.xml/feature.xml/plugin.xml). - Reformat
edu.cuny.citytech.refactoring.common.updatesite/category.xmlto match the indentation and multi-line<description>structure used insite.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
pom.xml |
Adds **/category.xml to the Spotless XML-format excludes to prevent unwanted formatter rewrites. |
edu.cuny.citytech.refactoring.common.updatesite/category.xml |
Adjusts indentation and moves <description> text to its own line to match site.xml formatting and avoid leading-space rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
khatchad
added a commit
that referenced
this pull request
Jun 18, 2026
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa
khatchad
added a commit
that referenced
this pull request
Jun 18, 2026
…52) * Prototype: CI-published p2 update site via GitHub Pages composite repo Replaces the in-repo, cumulative, hand-assembled update site with a CI-built, Pages-published p2 composite repository (no binaries in master). See docs/RELEASING.md for the comparison. - Add updatesite/category.xml so Tycho's eclipse-repository build produces a complete per-version p2 repo (fixes the empty-build quirk; no GUI / p2 publisher / -append needed). - Add tools/p2-composite.sh to generate p2 composite indexes; verified the Eclipse p2 director loads the composite and resolves the feature. - Add .github/workflows/release.yml: manual-dispatch release pipeline (set-version, build/test, tag + GitHub Release with the p2 repo zip, publish to gh-pages as a composite, next-dev bump). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa * Restyle RELEASING.md: title-case headers, no-space em-dashes, no line wrapping Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa * Drop category.xml from prototype (merged separately via #53/#54) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa * Commit the release version before tagging in release.yml The tag must point at the release-version sources, and master needs a "Release vX.Y.Z." commit, so commit the version bump and push master before tagging (mirrors release.sh). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015krtPy49YGqBERvq4yDjCa --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the review note on #53: the category
<description>rendered with a leading space because spotless's eclipseWtp XML formatter collapsed it onto one line.Fix: add
category.xmlto the spotless XML-format excludes (alongside its sibling hand-authored Eclipse descriptorssite.xml/feature.xml/plugin.xml), and reformat the description on its own line to matchsite.xml.Verified:
spotless:checkgreen and no longer rewritescategory.xml;clean installstill produces a populatedtarget/repository.🤖 Generated with Claude Code