Skip to content

Add addSpinnerButton to InputPage for bounded integer settings (#56) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khatchad merged 1 commit into from
Jun 22, 2026
Merged

Add addSpinnerButton to InputPage for bounded integer settings (#56) #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions ...citytech.refactoring.common.ui/src/edu/cuny/citytech/refactoring/common/ui/InputPage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Composite;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Spinner;
import org.eclipse.swt.widgets.Text;
import org.eclipse.ui.PlatformUI;

Expand Down Expand Up @@ -80,6 +81,41 @@ protected void addIntegerButton(String text, String key, int defaultValue, Consu
});
}

/**
* Adds a {@link Spinner} control for a small bounded positive integer setting. Like
* {@link #addIntegerButton(String, String, int, Consumer, Composite)}, this seeds {@code defaultValue} into the dialog settings if
* {@code key} is absent. Unlike the free-text {@link Text}-backed integer button, the spinner offers up/down steppers, enforces
* integer-only input, and pins a {@code minimum}, eliminating the silent parse-failure path.
*
* @param text The label for the control.
* @param key The dialog settings key under which the value is stored.
* @param defaultValue The value seeded into the settings when {@code key} is absent.
* @param minimum The smallest value the spinner allows.
* @param valueConsumer Receives the initial value and each subsequent change.
* @param result The composite to which the control is added.
*/
protected void addSpinnerButton(String text, String key, int defaultValue, int minimum, Consumer<Integer> valueConsumer,
Composite result) {
if (this.settings.get(key) == null)
this.settings.put(key, defaultValue);

Label label = new Label(result, SWT.HORIZONTAL);
label.setText(text);

Spinner spinner = new Spinner(result, SWT.BORDER);
spinner.setMinimum(minimum);
spinner.setSelection(this.settings.getInt(key));
Comment on lines +105 to +107
// Read back the (possibly minimum-clamped) selection so the consumer and settings stay consistent with the control.
int value = spinner.getSelection();
this.settings.put(key, value);
valueConsumer.accept(value);
spinner.addModifyListener(event -> {
int selection = ((Spinner) event.widget).getSelection();
InputPage.this.settings.put(key, selection);
valueConsumer.accept(selection);
});
}

@Override
public void createControl(Composite parent) {
ProcessorBasedRefactoring processorBasedRefactoring = (ProcessorBasedRefactoring) this.getRefactoring();
Expand Down
Loading