Bundle commons-io with common.eval to satisfy commons-csv#65
Merged
Conversation
commons-csv 1.12.0, bundled on common.eval's Bundle-ClassPath, has a hard dependency on commons-io 2.17.0 (it references org.apache.commons.io.output.AppendableOutputStream). That dependency was never declared, so under strict OSGi classloading the bundle's classloader cannot find the class, yielding a NoClassDefFoundError in a materialized product even when a separate commons-io bundle is present. The target platform is pure Eclipse update sites with no Orbit/commons bundles, which is why commons-csv is bundled as a jar in the first place, so depending on the org.apache.commons.csv bundle is not viable. Instead, bundle commons-io 2.17.0 the same way commons-csv is bundled: self-contained, works in both the IDE/test target and a materialized product, and private to this bundle's classloader (not exported), so it does not split-package with a product's own commons-io. Fixes #64. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015jRmWZMAqpMDjsKmTATy3A
commons-io with common.eval to satisfy commons-csv
commons-io with common.eval to satisfy commons-csvcommons-io with common.eval to satisfy commons-csv
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
edu.cuny.citytech.refactoring.common.evalbundle carries commons-csv 1.12.0 as a private jar on its ownBundle-ClassPath, but commons-csv 1.12.0 has a hard dependency on commons-io 2.17.0. It referencesorg.apache.commons.io.output.AppendableOutputStream. That dependency was never declared (it appeared when commons-csv was upgraded 1.10.0 to 1.12.0 in 7024035), so under strict OSGi classloading the bundle's classloader cannot find the class:This passes in the IDE/test target (looser resolution) but fails in a materialized product, even when a separate commons-io bundle is present, because there is no wiring from
common.evalto commons-io.Fix
The target platform (
common.target) is pure Eclipse update sites with no Orbit/commons bundles, which is precisely why commons-csv is bundled as a jar rather than consumed as theorg.apache.commons.csvbundle. So the issue's Option 2 (depend on that bundle) is not viable in-repo. Instead, this PR bundles commons-io 2.17.0 the same way commons-csv is bundled (the exact version commons-csv 1.12.0's POM pins):lib/commons-io-2.17.0.jar(plus sources/javadoc) tolib/.Bundle-ClassPath(META-INF/MANIFEST.MF).bin.includes(build.properties) so Tycho packages it..classpath) for IDE development.commons-io is not exported. It stays private to this bundle's classloader, so it does not split-package with a product's own commons-io bundle. This is self-contained and works in both the IDE/test target and a materialized product.
Fixes #64.
🤖 Generated with Claude Code