src: Fix (un)maximize usage for GNOME 49.

The API had changed here:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4415

Thus we had warnings being logged when in stacked mode. The commit
which added support for GNOME 49 forgot to change that.

Also, to be in line with the fixes commit, we remove the
	unmaxize(HORIZONTAL);
	unmaximize(VERTICAL);
	unmaximize(BOTH);
code to checking for whether the window is maximized and then using
BOTH (i.e. its replacement) directly.

Closes: #1801
Fixes: d22d2ff ("fix: update window maximization logic to use new properties and added gnome 49 shell version in metadata")
Signed-off-by: Siddh Raman Pant <25429745+siddhpant@users.noreply.github.com>

Author: siddhpant

src/extension.ts

@@ -909,10 +909,10 @@ export class Ext extends Ecs.System<ExtEvent> {
             ) {
                 if (prev.rect().contains(win.rect())) {
                     if (prev.is_maximized()) {
-                        prev.meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                        prev.meta.unmaximize();
                     }
                 } else if (prev.stack) {
-                    prev.meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                    prev.meta.unmaximize();
                     this.auto_tiler.forest.stacks.get(prev.stack)?.restack();
                 }
             }
@@ -1034,7 +1034,7 @@ export class Ext extends Ecs.System<ExtEvent> {
                     compare.is_maximized() &&
                     win.entity[0] !== compare.entity[0]
                 ) {
-                    compare.meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                    compare.meta.unmaximize();
                 }
             }
         }
@@ -1257,18 +1257,16 @@ export class Ext extends Ecs.System<ExtEvent> {
             }
 
             if (this.auto_tiler) {
-                if (this.is_floating(win)) {
-                    win.meta.unmaximize(Meta.MaximizeFlags.HORIZONTAL);
-                    win.meta.unmaximize(Meta.MaximizeFlags.VERTICAL);
-                    win.meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                if (this.is_floating(win) && win.is_maximized()) {
+                    win.meta.unmaximize();
                 }
 
                 this.register(Events.window_move(this, win, rect));
             } else {
                 win.move(this, rect, () => { });
                 // if the resulting dimensions of rect == next
                 if (rect.width == next_area.width && rect.height == next_area.height) {
-                    win.meta.maximize(Meta.MaximizeFlags.BOTH);
+                    win.meta.maximize();
                 }
             }
         }

src/mod.d.ts

@@ -306,13 +306,15 @@ declare namespace Meta {
         is_skip_taskbar(): boolean;
         make_above(): void;
         make_fullscreen(): void;
-        maximize(flags: MaximizeFlags): void;
+        maximize(): void;
+        unmaximize(): void;
+        unminimize(): void;
+        set_maximize_flags(flags: MaximizeFlags): void;
+        set_unmaximize_flags(flags: MaximizeFlags): void;
         move_frame(user_op: boolean, x: number, y: number): void;
         move_resize_frame(user_op: boolean, x: number, y: number, w: number, h: number): boolean;
         raise(): void;
         skip_taskbar: boolean;
-        unmaximize(flags: any): void;
-        unminimize(): void;
     }
 
     interface WindowActor extends Clutter.Actor {

src/tiling.ts

@@ -758,7 +758,7 @@ export class Tiler {
             this.window = win.entity;
 
             if (win.is_maximized()) {
-                win.meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                win.meta.unmaximize();
             }
 
             // Set overlay to match window

src/window.ts

@@ -373,7 +373,7 @@ export class ShellWindow {
 
         if (actor) {
             if (this.is_maximized()) {
-                meta.unmaximize(Meta.MaximizeFlags.BOTH);
+                meta.unmaximize();
             }
             actor.remove_all_transitions();