switch to static build for windows

Author: popmonkey

.github/workflows/win-build.yml

@@ -63,6 +63,7 @@ jobs:
           -DCMAKE_BUILD_TYPE=Release `
           -DCMAKE_PREFIX_PATH="$env:HIGHS_DIR" `
           -DCMAKE_INSTALL_PREFIX="${{ github.workspace }}\dist" `
+          -DBUILD_SHARED_LIBS=OFF `
           -DJRES_VERSION="${{ inputs.version }}"
 
     - name: Add Build Dir to PATH
@@ -121,15 +122,10 @@ jobs:
         Copy-Item "dist\bin\jres_solver.exe" -Destination "$pkg\bin\"
         Copy-Item "dist\bin\jres_formatter.exe" -Destination "$pkg\bin\"
         
-        # Library (Handle DLLs and LIBs)
-        # Copy import libraries (.lib) to lib folder
+        # Library (static)
         if (Test-Path "dist\lib\jres_solver.lib") {
             Copy-Item "dist\lib\jres_solver.lib" -Destination "$pkg\lib\"
         }
-        # Copy runtime libraries (.dll) to bin folder (typical windows convention)
-        if (Test-Path "dist\bin\jres_solver.dll") {
-            Copy-Item "dist\bin\jres_solver.dll" -Destination "$pkg\bin\"
-        }
         
         # Specific Header
         Copy-Item "dist\include\jres_solver\jres_solver.hpp" -Destination "$pkg\include\jres_solver\"

CMakeLists.txt

@@ -166,9 +166,11 @@ set_target_properties(jres_solver_lib PROPERTIES OUTPUT_NAME "jres_solver")
 
 if(WIN32)
     target_sources(jres_solver_lib PRIVATE ${VERSION_RC})
-    # Only export symbols if we are actually building shared
+    
     if(BUILD_SHARED_LIBS)
         target_compile_definitions(jres_solver_lib PRIVATE JRES_SOLVER_EXPORTS)
+    else()
+        target_compile_definitions(jres_solver_lib PUBLIC JRES_STATIC)
     endif()
 endif()
 

include/jres_solver/jres_solver.hpp

@@ -13,10 +13,15 @@
 #define JRES_SOLVER_HPP
 
 #if defined(_WIN32)
-    // Windows/MSVC: Use __declspec(dllexport/dllimport)
-    #ifdef JRES_SOLVER_EXPORTS
+    // Windows/MSVC: Handle DLL exports, imports, AND static builds
+    #if defined(JRES_STATIC)
+        // Static build: No special attributes needed
+        #define JRES_SOLVER_API
+    #elif defined(JRES_SOLVER_EXPORTS)
+        // Building the DLL: Export symbols
         #define JRES_SOLVER_API __declspec(dllexport)
     #else
+        // Using the DLL: Import symbols
         #define JRES_SOLVER_API __declspec(dllimport)
     #endif
 #else