Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
massive rewrite to provide an interface that doesn't require json input but more importantly accepts a list of stints instead of building one itself.
this allows the caller to control individual stint length in order to account for daytime/nighttime, weather. it was a mistake to have v1 synthesize the list of stints given that all the tools, including our spreadsheet, already do that part.
note that this will no longer work with the output from the v1.0 JRES Spreadsheet
v2.0 requires input from the v2.0 JRES Spreadsheet
i also fix #32 while we're at it.